python310Packages.ansible-pylibssh: patch out setuptools_scm_git_archive#251679
Merged
tjni merged 1 commit intoNixOS:staging-nextfrom Aug 26, 2023
tjni:ansible-pylibssh
Merged
python310Packages.ansible-pylibssh: patch out setuptools_scm_git_archive#251679tjni merged 1 commit intoNixOS:staging-nextfrom tjni:ansible-pylibssh
tjni merged 1 commit intoNixOS:staging-nextfrom
tjni:ansible-pylibssh
Conversation
Contributor
Author
|
I'm going to merge this for now to fix these failing builds on staging-next, but I am happy to address any feedback you send my way on how this should be done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
I missed in #247367 that setuptools_scm_git_archive is still requested in pyproject.toml. This only fails on staging-next because of Python bootstrapping changes there.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)