pythonPackages.ansible-pylibssh: init at 1.1.0#247367
Merged
tjni merged 4 commits intoNixOS:masterfrom Aug 24, 2023
Merged
Conversation
00223ec to
7df46ad
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2533 |
tjni
reviewed
Aug 23, 2023
Contributor
tjni
left a comment
There was a problem hiding this comment.
Thank you for contributing, and I'm sorry for the delay in reviewing your contribution.
This allows usage of pylibssh in Ansible instead of paramiko.
Contributor
Author
|
Thank you for the review! And no worries about the delay, I'm happy you were able to take a look at it. |
tjni
approved these changes
Aug 24, 2023
Contributor
tjni
left a comment
There was a problem hiding this comment.
Thank you for your hard work.
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR adds a new Python package, pylibssh. This package provides SSH functionality to Ansible. By default, such functionality is provided by
paramiko, but using pylibssh is recommended as it provides more functionality, and will eventually be made the default, as explained here.As
pylibsshdepends on expandvars, which is not yet present in Nixpkgs, this package is also added.Things done
For non-Linux: Issandbox = trueset innix.conf? (See Nix manual)Tested compilation of all packages that depend on this change usingnix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage(Package updates) Added a release notes entry if the change is major or breaking(Module updates) Added a release notes entry if the change is significant(Module addition) Added a release notes entry if adding a new NixOS module