gcc: deduplicate version expressions#250489
Merged
21 commits merged intostagingfrom Aug 21, 2023
unknown repository
Merged
Conversation
added 4 commits
August 20, 2023 22:52
This commit lifts the default gcc version to a top-level attribute so it can be overridden.
added 16 commits
August 20, 2023 22:59
This was referenced Aug 21, 2023
Author
|
The last merge of Since this is strictly cleanup (no change after eval), in order to prevent that from happening again I am merging this to both |
AndersonTorres
pushed a commit
that referenced
this pull request
Sep 11, 2023
This PR sorts the huge pile of patches and deduplicates it. Unlike its predecessors #249707 and #250489 this commit *does* affect eval. Patches below are organized into three general categories: 1. Patches relevant to gcc>=12 on every platform 2. Patches relevant to gcc>=12 on specific platforms 3. Patches relevant only to gcc<12, sorted by the newest version to which they might be relevant
ConnorBaker
pushed a commit
to nixos-cuda/cuda-legacy
that referenced
this pull request
Apr 14, 2025
This PR sorts the huge pile of patches and deduplicates it. Unlike its predecessors NixOS/nixpkgs#249707 and NixOS/nixpkgs#250489 this commit *does* affect eval. Patches below are organized into three general categories: 1. Patches relevant to gcc>=12 on every platform 2. Patches relevant to gcc>=12 on specific platforms 3. Patches relevant only to gcc<12, sorted by the newest version to which they might be relevant
ConnorBaker
pushed a commit
to nixos-cuda/cuda-legacy
that referenced
this pull request
Apr 14, 2025
This commit simplifies our gcc expression by applying various workarounds unconditionally, rather than only to exactly the versions which applied them prior to the deduplication cleanup. Unlike its predecessors NixOS/nixpkgs#249707 and NixOS/nixpkgs#250489 this commit *does* affect eval.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Rebase to
stagingof:See this comment. I am going to take advantage of the current short window where
masterandstagingare in sync to merge this to both branches, since it:gccWaiting for ofborg to go green.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)