Skip to content

[staging-next] treewide: pin packages that don't build with new protobuf to old protobuf#249752

Merged
K900 merged 1 commit intoNixOS:staging-nextfrom
K900:pin-old-protobuf-some
Aug 18, 2023
Merged

[staging-next] treewide: pin packages that don't build with new protobuf to old protobuf#249752
K900 merged 1 commit intoNixOS:staging-nextfrom
K900:pin-old-protobuf-some

Conversation

@K900
Copy link
Copy Markdown
Contributor

@K900 K900 commented Aug 17, 2023 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@K900 K900 requested a review from ttuegel as a code owner August 17, 2023 15:07
@github-actions github-actions bot added the 6.topic: qt/kde Object-oriented framework for GUI creation label Aug 17, 2023
@K900 K900 force-pushed the pin-old-protobuf-some branch 2 times, most recently from 2a26d3f to 5de888e Compare August 17, 2023 15:28
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 17, 2023
@ofborg ofborg bot requested review from LnL7 and marsam August 17, 2023 16:13
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 17, 2023
@K900
Copy link
Copy Markdown
Contributor Author

K900 commented Aug 17, 2023

Result of nixpkgs-review pr 249752 run on x86_64-linux 1

1 package marked as broken and skipped:
  • zombietrackergps
16 packages built:
  • adb-sync
  • adbfs-rootless
  • agi
  • android-tools
  • clementine
  • digikam
  • fdroidcl
  • libmysqlconnectorcpp
  • libsForQt5.marble
  • libsForQt5.marble.dev
  • mosh
  • mysql-workbench
  • mysql80
  • mysql80.static
  • netdata
  • scrcpy

@K900 K900 force-pushed the pin-old-protobuf-some branch from 9a905b3 to 2a512eb Compare August 17, 2023 16:38
@vcunat
Copy link
Copy Markdown
Member

vcunat commented Aug 18, 2023

android-tools alternative: #249692

tobim
tobim approved these changes Aug 18, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

android-tools alternative: #249692

We can also just take this PR and wait for a new tarball upload of android-tools.

vcunat pushed a commit that referenced this pull request Aug 18, 2023
@K900 @vcunat
grpc: fix generated config file
3997698 
Taken from PR #249752
@K900 K900 force-pushed the pin-old-protobuf-some branch from 2a512eb to e631034 Compare August 18, 2023 15:41
@K900 K900 merged commit edeb363 into NixOS:staging-next Aug 18, 2023
@tjni tjni mentioned this pull request Aug 19, 2023
Closed
@K900 K900 deleted the pin-old-protobuf-some branch July 27, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

@marsam marsam Awaiting requested review from marsam

@LnL7 LnL7 Awaiting requested review from LnL7

1 more reviewer

@tobim tobim tobim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: qt/kde Object-oriented framework for GUI creation 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@K900 @vcunat @tobim