Skip to content

cargo-auditable-cargo-wrapper: fix wrapper#248957

Merged
tjni merged 2 commits intoNixOS:stagingfrom
figsoda:auditable
Aug 23, 2023
Merged

cargo-auditable-cargo-wrapper: fix wrapper#248957
tjni merged 2 commits intoNixOS:stagingfrom
figsoda:auditable

Conversation

@figsoda
Copy link
Copy Markdown
Member

@figsoda figsoda commented Aug 13, 2023

Description of changes

Packages were not correctly built with carog-auditable due to the missing auditable flag. Looks like this was accidently disabled in #227992

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@figsoda
cargo-auditable-cargo-wrapper: fix wrapper
8522d78 
Packages were not correctly built with carog-auditable due to the
missing auditable flag
@github-actions github-actions bot added the 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. label Aug 13, 2023
@figsoda figsoda mentioned this pull request Aug 13, 2023
Merged
12 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Aug 13, 2023
@figsoda
Copy link
Copy Markdown
Member Author

figsoda commented Aug 13, 2023

@ofborg eval

@nixos-discourse
Copy link
Copy Markdown

nixos-discourse commented Aug 23, 2023

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2581

@tjni tjni merged commit 73cee93 into NixOS:staging Aug 23, 2023
@figsoda figsoda deleted the auditable branch August 23, 2023 15:56
@tomhoule tomhoule mentioned this pull request Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

@zowoq zowoq Awaiting requested review from zowoq

@winterqt winterqt Awaiting requested review from winterqt

1 more reviewer

@tjni tjni tjni approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@figsoda @nixos-discourse @tjni