cargo-auditable-cargo-wrapper: use makeWrapper#227992
Merged
alyssais merged 2 commits intoNixOS:stagingfrom Apr 24, 2023
Merged
cargo-auditable-cargo-wrapper: use makeWrapper#227992alyssais merged 2 commits intoNixOS:stagingfrom
alyssais merged 2 commits intoNixOS:stagingfrom
Conversation
figsoda
reviewed
Apr 24, 2023
Comment on lines
11
to
12
Member
There was a problem hiding this comment.
Suggested change
| --set CARGO_AUDITABLE_IGNORE_UNSUPPORTED 1 \ | |
| --prefix PATH : ${lib.makeBinPath [ cargo cargo-auditable ]} | |
| --set CARGO_AUDITABLE_IGNORE_UNSUPPORTED 1 \ | |
| --prefix PATH : ${lib.makeBinPath [ cargo cargo-auditable ]} |
Member
Author
There was a problem hiding this comment.
Use 2 spaces of indentation per indentation level in Nix expressions, 4 spaces in shell scripts.
I've always read this is meaning 4 spaces inside shell scripts inside Nix expressions, but I suppose the other reading is valid.
e0c6b20 to
9ac3a64
Compare
figsoda
approved these changes
Apr 24, 2023
This was referenced Aug 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)