Skip to content

invoice2data: clean up some build and runtime dependencies#248798

Merged
tjni merged 1 commit intoNixOS:masterfrom
tjni:invoice2data
Aug 17, 2023
Merged

invoice2data: clean up some build and runtime dependencies#248798
tjni merged 1 commit intoNixOS:masterfrom
tjni:invoice2data

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 12, 2023

Description of changes

This change does the following:

  1. Pull in a patch to remove unnecessary pip and pytest-runner dependencies in setup.cfg.
  2. Move setuptools-git into nativeBuildInputs, where it belongs.
  3. Remove chardet, which was removed in Treat all YAML templates files as UTF-8 encoded invoice-x/invoice2data#449.
  4. Remove setuptools, which is not needed at runtime.
  5. Remove unidecode, which was removed in [REM] unidecode library invoice-x/invoice2data#436.

This package has an updated version (version 0.4.4), but I don't feel prepared to update it yet. It's also nontrivial to get the tests working again, so I've skipped doing that in this PR.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from PsyanticY August 13, 2023 00:00
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 13, 2023
@tjni tjni merged commit 7a706c0 into NixOS:master Aug 17, 2023
@tjni tjni deleted the invoice2data branch August 17, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant