invoice2data: clean up some build and runtime dependencies#248798
Merged
tjni merged 1 commit intoNixOS:masterfrom Aug 17, 2023
tjni:invoice2data
Merged
invoice2data: clean up some build and runtime dependencies#248798tjni merged 1 commit intoNixOS:masterfrom tjni:invoice2data
tjni merged 1 commit intoNixOS:masterfrom
tjni:invoice2data
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This change does the following:
pipandpytest-runnerdependencies in setup.cfg.chardet, which was removed in Treat all YAML templates files as UTF-8 encoded invoice-x/invoice2data#449.setuptools, which is not needed at runtime.unidecode, which was removed in [REM] unidecode library invoice-x/invoice2data#436.This package has an updated version (version 0.4.4), but I don't feel prepared to update it yet. It's also nontrivial to get the tests working again, so I've skipped doing that in this PR.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)