Treat all YAML templates files as UTF-8 encoded#449
Merged
rmilecki merged 1 commit intoinvoice-x:masterfrom Jan 25, 2023
Merged
Treat all YAML templates files as UTF-8 encoded#449rmilecki merged 1 commit intoinvoice-x:masterfrom
rmilecki merged 1 commit intoinvoice-x:masterfrom
Conversation
Collaborator
rmilecki
commented
Jan 21, 2023
Encoding detection based on chardet is unreliable. For UTF-8 encoded files with few non-ASCII chars it often fails to detect UTF-8. That results in invoices not being parsed correctly. Read every YAML file as UTF-8 encoded. It is used by all project internal templates. It should be used by all external ones too. FWIW YAML documentation also says that every *processor* must support the UTF-8, UTF-16 and UTF-32: https://yaml.org/spec/1.2.2/#52-character-encodings Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Collaborator
Author
|
This fixes:
It's an alternative solution to the #446 . I'm not sure we should / have to support any other encoding. |
This was referenced Jan 25, 2023
Closed
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.