Skip to content

python3.pkgs.pandas: add missing build dependencies#248623

Merged
FRidh merged 1 commit intoNixOS:stagingfrom
tjni:pandas
Aug 12, 2023
Merged

python3.pkgs.pandas: add missing build dependencies#248623
FRidh merged 1 commit intoNixOS:stagingfrom
tjni:pandas

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 12, 2023

Description of changes

Adding these dependencies explicitly will enable building with build (work tracked by #247287). I have also cleaned up the hardeningDisable property, which is no longer needed after #243595.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tjni tjni mentioned this pull request Aug 12, 2023
Closed
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 12, 2023
@ofborg ofborg bot requested review from 7c6f434c, FRidh and knedlsepp August 12, 2023 03:37
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Aug 12, 2023
@FRidh FRidh merged commit c9c027e into NixOS:staging Aug 12, 2023
@tjni tjni deleted the pandas branch August 12, 2023 06:13
tjni added a commit that referenced this pull request Aug 16, 2023
@tjni
python3.pkgs.pandas: add missing build dependencies (#248623)
67e371a
tjni added a commit that referenced this pull request Aug 16, 2023
@tjni
python3.pkgs.pandas: add missing build dependencies (#248623)
eaafb77
tjni added a commit that referenced this pull request Aug 17, 2023
@tjni
python3.pkgs.pandas: add missing build dependencies (#248623)
06f645f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@FRidh FRidh Awaiting requested review from FRidh

@knedlsepp knedlsepp Awaiting requested review from knedlsepp

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tjni @FRidh