python3.pkgs.protobuf: fix build after updating protobuf to 3.23.4#248231
Merged
FRidh merged 1 commit intoNixOS:staging-nextfrom Aug 12, 2023
tjni:protobuf
Merged
python3.pkgs.protobuf: fix build after updating protobuf to 3.23.4#248231FRidh merged 1 commit intoNixOS:staging-nextfrom tjni:protobuf
FRidh merged 1 commit intoNixOS:staging-nextfrom
tjni:protobuf
Conversation
Member
|
Result of 170 packages marked as broken and skipped:
4084 packages failed to build:
|
Contributor
Author
|
🤯 How were you able to run nixpkgs-review against staging? 🥇 Do you have some error messages? I don't have x86_64-linux, but I can perhaps cherry-pick the relevant changes onto master and run them on an aarch64-linux VM. |
Member
|
Sorry, I did it without thinking.😅 |
Contributor
Author
|
No problem! Thank you for all your help reviewing. |
tobim
approved these changes
Aug 10, 2023
Contributor
tobim
left a comment
There was a problem hiding this comment.
Thanks for fixing this so quickly!
Contributor
Author
|
Retargeted against staging-next: #248496 |
Contributor
|
Doesn't build with GCC because it forces c++14: https://github.com/protocolbuffers/protobuf/blob/2eee41224e2eac1aa4e8e8f4a28ff11748e49a41/python/setup.py#L373 |
Contributor
Author
|
That's a very good catch, thank you for pointing it out. I deleted the line unconditionally (from some brief research, it seems like only really old compilers do not default to at least C++14), but we can exclude a compiler if we identify it defaults to an older version. Verified that the build used to break with GCC and now it passes. |
Member
|
Works for me on x86_64-linux. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This is a follow up to #244539. The new version requires adding abseil-cpp to the include path in setup.py, adds a numpy test, and also has a change that breaks some tests that I had to disable since I couldn't figure out how to fix them.
/cc @tobim
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)