Merged
Conversation
marsam
reviewed
Aug 5, 2023
f17af6c to
9e397b9
Compare
marsam
approved these changes
Aug 5, 2023
12 tasks
12 tasks
Contributor
|
protobuf-c is broken and it looks like they haven't released a version that supports 22.x or 23.x yet. I did find protobuf-c/protobuf-c#673, which indicates support should be present in their @NickCao, do you have a preference on what to do? |
Member
Let's bump to the version in |
Contributor
|
I opened #248306. Adding abseil-cpp to propagatedBuildInputs was indeed needed. I don't have the ability to test this on Linux; I could only test it on aarch64-darwin since I had already built all of the stuff on staging. |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
https://github.com/protocolbuffers/protobuf/releases/tag/v23.4
v22 is also not packaged, but since it hasn't been added so far I think we can leave a gap.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)