[next] libgit2_1_6: init at 1.6.4#247408
Conversation
Some packages still depend on libgit2 1.6
|
Could you please also add jami to this MR? I thought it also requires libgit2 2.16. See https://hydra.nixos.org/build/229965246. |
|
jami got fixed by fa3ea76 and builds already: https://hydra.nixos.org/build/230406259 |
|
Same with all the other packages in this PR as well, so I assume this PR won't be needed anymore. gql still fails on *-darwin but that probably won't get helped by libgit2 changes (instead, the Security framework should be provided) |
It requires the Security framework when used with libgit2 1.7 because it is falling back to the vendored version of libgit2 and is not using the libgit2 dependency at all: #247398 (comment). This patch fixes it on darwin as shown by ofborg.
Same for The same applies to nix-init. The package already builds, but was not linking to libgit2, and downgrading libgit2 fixes the linking issue. pygit2 is already using libgit2 1.6, I just lifted the override to top level I will remove jami since that seems to be caused by a libgit2 bug that has been patched now |
Some packages still depend on libgit2 1.6
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)