gql: add Security framework dependency on darwin#247398
Closed
tjni wants to merge 1 commit intoNixOS:staging-nextfrom
tjni:gql
Closed
gql: add Security framework dependency on darwin#247398tjni wants to merge 1 commit intoNixOS:staging-nextfrom tjni:gql
tjni wants to merge 1 commit intoNixOS:staging-nextfrom
tjni:gql
Conversation
Member
|
I opened #247408 to add back libgit2 1.6 like we did for 1.5 and 1.3, so packages like this can still link to libgit2, and |
Contributor
Author
|
Got it, do you know why this is happening? I don't have a good instinct about how transitive dependencies are or are not propagated. |
Member
|
The |
Contributor
Author
|
Wow, what a footgun. Can you also revert my change in #247387? |
Member
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This is broken in staging-next (#245935). Related to libgit2 being updated from 1.6.4 to 1.7.0.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)