Skip to content

python3.pkgs.jsonschema: add pip test dependency#247311

Merged
FRidh merged 1 commit intoNixOS:stagingfrom
tjni:jsonschema
Aug 12, 2023
Merged

python3.pkgs.jsonschema: add pip test dependency#247311
FRidh merged 1 commit intoNixOS:stagingfrom
tjni:jsonschema

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 5, 2023

Description of changes

This is needed but hidden by the fact that right now the Python setup hooks add pip to the environment.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 5, 2023
@tjni tjni mentioned this pull request Aug 5, 2023
Closed
@ofborg ofborg bot requested a review from domenkozar August 5, 2023 11:38
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Aug 5, 2023
@FRidh
Copy link
Copy Markdown
Member

FRidh commented Aug 7, 2023

Won't this cause a collision as it is now?

@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Aug 7, 2023

Won't this cause a collision as it is now?

I am honestly not sure why there isn't one. I echoed $PYTHONPATH and ran

${python.interpreter} -c "import sys;print(sys.path)"

in the preCheck phase, and neither showed pip more than once. The package still seems to build too. With that said, I also don't mind sitting on this until we can push everything together.

@FRidh FRidh merged commit 6203061 into NixOS:staging Aug 12, 2023
@tjni tjni deleted the jsonschema branch August 12, 2023 06:13
tjni added a commit that referenced this pull request Aug 16, 2023
@tjni
python3.pkgs.jsonschema: add pip test dependency (#247311)
0ffb03b
tjni added a commit that referenced this pull request Aug 16, 2023
@tjni
python3.pkgs.jsonschema: add pip test dependency (#247311)
600f0b3
tjni added a commit that referenced this pull request Aug 17, 2023
@tjni
python3.pkgs.jsonschema: add pip test dependency (#247311)
a1d6df4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tjni @FRidh