Skip to content

python3.pkgs.astroid: add wheel and pip dependencies#247258

Merged
FRidh merged 1 commit intoNixOS:stagingfrom
tjni:astroid
Aug 12, 2023
Merged

python3.pkgs.astroid: add wheel and pip dependencies#247258
FRidh merged 1 commit intoNixOS:stagingfrom
tjni:astroid

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 5, 2023

Description of changes

This will be needed by (and is extracted from) #245509 for ease of reviewing. This PR adds two dependencies to astroid that were implicitly provided by Python setup hooks but will no longer be.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 5, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Aug 5, 2023
@tjni tjni marked this pull request as draft August 5, 2023 03:07
@tjni tjni changed the base branch from master to staging August 5, 2023 03:07
@tjni tjni marked this pull request as ready for review August 5, 2023 03:07
@tjni tjni mentioned this pull request Aug 5, 2023
Closed
@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Aug 5, 2023

@ofborg eval

@ofborg ofborg bot added 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. and removed 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Aug 5, 2023
@figsoda figsoda added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 9, 2023
@FRidh FRidh merged commit f06e634 into NixOS:staging Aug 12, 2023
@tjni tjni deleted the astroid branch August 12, 2023 06:13
tjni added a commit that referenced this pull request Aug 16, 2023
@tjni
python3.pkgs.astroid: add wheel and pip dependencies (#247258)
4807058
tjni added a commit that referenced this pull request Aug 16, 2023
@tjni
python3.pkgs.astroid: add wheel and pip dependencies (#247258)
7c772f7
tjni added a commit that referenced this pull request Aug 17, 2023
@tjni
python3.pkgs.astroid: add wheel and pip dependencies (#247258)
a083287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tjni @SuperSandro2000 @FRidh @figsoda