Skip to content

djvulibre: patch multiple CVEs#246773

Merged
vcunat merged 1 commit intoNixOS:masterfrom
henrirosten:djvulibre_add_reviewed_fedora_patches
Aug 30, 2023
Merged

djvulibre: patch multiple CVEs#246773
vcunat merged 1 commit intoNixOS:masterfrom
henrirosten:djvulibre_add_reviewed_fedora_patches

Conversation

@henrirosten
Copy link
Copy Markdown
Member

@henrirosten henrirosten commented Aug 2, 2023

Description of changes

Add patches from https://sourceforge.net/p/djvu/djvulibre-git/ci/cd8b5c97b27a5c1dc83046498b6ca49ad20aa9b6.
These changes address the following CVEs:

Ref: #132114

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
@ofborg ofborg bot requested a review from Anton-Latukha August 2, 2023 12:56
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Aug 2, 2023
@henrirosten henrirosten marked this pull request as ready for review August 2, 2023 19:00
@henrirosten henrirosten added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Aug 2, 2023
@risicle
Copy link
Copy Markdown
Contributor

risicle commented Aug 3, 2023

No fetchpatch-able link?

:sadface:

Copy link
Copy Markdown
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully built imagemagick on macos 10.15 & nixos x86_64. Built okular and evince on nixos x86_64. Builds, aarch64-linux.

@risicle
Copy link
Copy Markdown
Contributor

risicle commented Aug 3, 2023

Though this may need to be retargeted at staging for darwin's sake.

@figsoda figsoda added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 9, 2023
@vcunat vcunat merged commit 2a12451 into NixOS:master Aug 30, 2023
@github-actions
Copy link
Copy Markdown
Contributor

Successfully created backport PR for release-23.05:

@imincik
Copy link
Copy Markdown
Contributor

imincik commented Aug 30, 2023

@vcunat ,

My other PR is not evaluating and the error message looks relevant to this PR.

@vcunat
Copy link
Copy Markdown
Member

vcunat commented Aug 30, 2023

Thanks, I'm sorry. Silent merge conflict. I'll resolve it immediately.

@vcunat
Copy link
Copy Markdown
Member

vcunat commented Aug 30, 2023

Resolved by PR #252327 I believe.

@imincik
Copy link
Copy Markdown
Contributor

imincik commented Aug 30, 2023

Resolved by PR #252327 I believe.

Yes, I confirm it is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants