rustc: remove Darwin special-casing#242749
Conversation
An attempt to remove it was made in NixOS#106886, but there was a build failure. Since that failure no longer occurs, remove it now. Based on thefloweringash/nixpkgs@1904236.
|
Just for clarity, what specifically changed that causes the failure not to occur anymore? Or can you not pin it down to the massive amount of work being put into the LLVM bump? |
zowoq
left a comment
There was a problem hiding this comment.
Sorry, I thought I'd removed this over a year ago ...
I can’t say, unfortunately. I was looking to bump the bootstrap version for the clang 16 bump when I found the old issue and the commit from @thefloweringash’s repo. I applied it to current nixpkgs, and it still works. I assume it’s a combination of improvements in the LLVM environment and Darwin packaging that resolved the missing symbol issue. |
Description of changes
An attempt to remove it was made in #106886, but there was a build failure. Since that failure no longer occurs, remove it now.
Based on thefloweringash/nixpkgs@1904236.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)