[staging] rust: cleanup, use correct llvm version#106886
Merged
Mic92 merged 1 commit intoNixOS:stagingfrom Dec 16, 2020
Merged
Conversation
Contributor
Fails to build on darwin. |
a120f3e to
091400e
Compare
091400e to
c73d96f
Compare
Contributor
Author
|
@zowoq Thx for testing, didn't have any darwin machine to test on. I've reverted those changes but in a way that is more obvious what is used for, hope it is ok. |
Member
|
Builds thunderbird on Linux. Can someone check building rustc on macOS? cc @dasJ |
Member
|
Result of 220 packages marked as broken and skipped:
518 packages failed to build:
|
Member
|
Contributor
Author
|
@dasJ This doesn't look related to rustc changes. Can you maybe cherry-pick it to latest master and try there? Thanks! |
Contributor
|
Built |
thefloweringash
added a commit
to thefloweringash/nixpkgs
that referenced
this pull request
Feb 1, 2021
There was an attempt to remove this in NixOS#106886 [1], but there was a darwin compilation failure. Whatever caused the failure then is no longer a problem now. [1] NixOS#106886
reckenrode
added a commit
to reckenrode/nixpkgs
that referenced
this pull request
Jul 10, 2023
An attempt to remove it was made in NixOS#106886, but there was a build failure. Since that failure no longer occurs, remove it now. Based on thefloweringash/nixpkgs@1904236.
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I've noticed rustc 1.48 uses LLVM 10 while version 11 is set in all-packages:
This change properly propagates correct runtime LLVM version.
I've also removed bootstrap overridefor clang based stdenv, which should be unnecessary, I didn't test it.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)