Skip to content

Revert "gettext: 0.21 -> 0.21.1"#235398

Closed
flokli wants to merge 1 commit intoNixOS:stagingfrom
flokli:revert-gettext-bump
Closed

Revert "gettext: 0.21 -> 0.21.1"#235398
flokli wants to merge 1 commit intoNixOS:stagingfrom
flokli:revert-gettext-bump

Conversation

@flokli
Copy link
Copy Markdown
Member

@flokli flokli commented Jun 1, 2023

d6628cf did already mention there's been no announcement yet. It looks like the source did change post- release.

Let's revert this and re-roll once we're certain the sources won't change anymore.

This reverts commit d6628cf.

staging currently fails with:

error: hash mismatch in fixed-output derivation '/nix/store/2c90gp52cvdprpj314d86qii9qil4fkb-gettext-0.21.1.tar.gz.drv':
         specified: sha256-6MNlDh2M7odcTzVWQjgsHfgwWL1aEe6FVcDPJ21kbUU=
            got:    sha256-97ddKLyBBjjVpNWg633BaeMOQwv3nxwH+YUTOpmX3tA=
Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

d6628cf did already mention there's
been no announcement yet. It looks like the source did change post-
release.

Let's revert this and re-roll once we're certain the sources won't
change anymore.

This reverts commit d6628cf.
@flokli flokli added the 1.severity: blocker This is preventing another PR or issue from being completed label Jun 1, 2023
@flokli flokli mentioned this pull request Jun 1, 2023
12 tasks
@flokli flokli requested a review from sternenseemann June 1, 2023 15:16
@flokli flokli mentioned this pull request Jun 1, 2023
12 tasks
@wegank
Copy link
Copy Markdown
Member

wegank commented Jun 1, 2023

I don't think reverting to 0.21 is a good idea, looking at https://repology.org/project/gettext/information.

@flokli
Copy link
Copy Markdown
Member Author

flokli commented Jun 1, 2023

I don't think it's a good idea, looking at https://repology.org/project/gettext/information.

Can you elaborate why it's not a good idea? It's an intermediate fix to unblock (unrelated) PRs to staging, we can re-roll a 0.21.1 bump once someone gets to it.

@wegank
Copy link
Copy Markdown
Member

wegank commented Jun 1, 2023

Can you elaborate why it's not a good idea?

Repology already suggests that more distros are on 0.21.1 than on 0.21, so whether there's an announcement or not, I think this version is well recognized as a new release.

The hash being still sha256-6MNlDh2M7odcTzVWQjgsHfgwWL1aEe6FVcDPJ21kbUU= on my machine in Paris, I think it's probably worth trying ways around the hash mismatch, such as going through Wayback Machine.

@reckenrode
Copy link
Copy Markdown
Contributor

If we revert until the hash stabilizes, I can open a PR to patch what was causing problems for the Darwin stdenv update. I was trying to be proactive before landing the actual bump, but blocking staging is no good.

@wegank
Copy link
Copy Markdown
Member

wegank commented Jun 1, 2023

I'll check if fetching directly from https://ftp.gnu.org/pub/gnu/gettext/${pname}-${version}.tar.gz helps. It's likely that some GNU mirrors are faulty.

EDIT: opened #235421.

@Mindavi Mindavi added the 6.topic: reproducible builds Run nix-build twice and get the same result. label Jun 1, 2023
@wegank wegank mentioned this pull request Jun 1, 2023
12 tasks
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. labels Jun 1, 2023
@ofborg ofborg bot requested review from vrthra and zimbatm June 1, 2023 18:03
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jun 1, 2023
@flokli
Copy link
Copy Markdown
Member Author

flokli commented Jun 1, 2023

It definitely seems to be some flaky mirror. Applying #235421 got it to download, but before, fetching was broken continuously.

It was the following derivation:

nix show-derivation /nix/store/2c90gp52cvdprpj314d86qii9qil4fkb-gettext-0.21.1.tar.gz.drv
{
  "/nix/store/2c90gp52cvdprpj314d86qii9qil4fkb-gettext-0.21.1.tar.gz.drv": {
    "args": [],
    "builder": "builtin:fetchurl",
    "env": {
      "builder": "builtin:fetchurl",
      "executable": "",
      "impureEnvVars": "http_proxy https_proxy ftp_proxy all_proxy no_proxy",
      "name": "gettext-0.21.1.tar.gz",
      "out": "/nix/store/y2h7bqjpc4q9g887w8pbwncjrmr4g9sx-gettext-0.21.1.tar.gz",
      "outputHash": "sha256-6MNlDh2M7odcTzVWQjgsHfgwWL1aEe6FVcDPJ21kbUU=",
      "outputHashAlgo": "sha256",
      "outputHashMode": "flat",
      "preferLocalBuild": "1",
      "system": "builtin",
      "unpack": "",
      "url": "https://ftpmirror.gnu.org/gettext/gettext-0.21.1.tar.gz",
      "urls": "https://ftpmirror.gnu.org/gettext/gettext-0.21.1.tar.gz"
    },
    "inputDrvs": {},
    "inputSrcs": [],
    "outputs": {
      "out": {
        "hash": "e8c3650e1d8cee875c4f355642382c1df83058bd5a11ee8555c0cf276d646d45",
        "hashAlgo": "sha256",
        "path": "/nix/store/y2h7bqjpc4q9g887w8pbwncjrmr4g9sx-gettext-0.21.1.tar.gz"
      }
    },
    "system": "builtin"
  }
}

I'm not sure explicitly hardcoding one place over the other is actually a good fix, though.

I wonder if we could do anything in the future to make this more debuggable, see which mirror specifically is buggy?

@flokli
Copy link
Copy Markdown
Member Author

flokli commented Jun 1, 2023

Closing this issue, this seems to have been one faulty mirror, will open a new discussion about this elsewhere and link from here.

@flokli
Copy link
Copy Markdown
Member Author

flokli commented Jun 1, 2023

I opened NixOS/nix#8432 to discuss the fetcher problem.

@flokli flokli deleted the revert-gettext-bump branch June 1, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: blocker This is preventing another PR or issue from being completed 6.topic: reproducible builds Run nix-build twice and get the same result. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants