Skip to content

gettext: don't fetch from mirrors#235421

Closed
wegank wants to merge 1 commit intoNixOS:stagingfrom
wegank:gettext-master
Closed

gettext: don't fetch from mirrors#235421
wegank wants to merge 1 commit intoNixOS:stagingfrom
wegank:gettext-master

Conversation

@wegank
Copy link
Copy Markdown
Member

@wegank wegank commented Jun 1, 2023

Description of changes

#235398 (comment)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@wegank
Copy link
Copy Markdown
Member Author

wegank commented Jun 1, 2023

@ofborg build gettext gettext.passthru.tests

@wegank
Copy link
Copy Markdown
Member Author

wegank commented Jun 1, 2023

cc @flokli

@wegank wegank mentioned this pull request Jun 1, 2023
12 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 1, 2023
@flokli
Copy link
Copy Markdown
Member

flokli commented Jun 1, 2023

Even though this got my build to work, I'm not sure this is the right fix in general. If some gnu mirror returned the wrong file, we maybe should log the exact mirror we downloaded from.

Let's close this PR?

@wegank wegank closed this Jun 1, 2023
@wegank wegank deleted the gettext-master branch June 1, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants