Skip to content

[RFC] version: Extend /etc/os-release#23190

Merged
copumpkin merged 1 commit intoNixOS:masterfrom
primeos:os-release
Feb 26, 2017
Merged

[RFC] version: Extend /etc/os-release#23190
copumpkin merged 1 commit intoNixOS:masterfrom
primeos:os-release

Conversation

@primeos
Copy link
Copy Markdown
Member

@primeos primeos commented Feb 25, 2017

  • Provide additional link for support and bug reporting.
  • Use HTTPS links (related: "The IAB encourages all web servers to
    employ TLS to protect their content, and use OCSP stapling to improve
    the efficiency and privacy of revocation checking." 0.
  • Add VERSION_CODENAME
Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Imho we should always use HTTPS links when possible (the support and bug report URLs are optional).
VERSION_CODENAME could be helpful for #23175 (but it works fine without).

- Provide additional link for support and bug reporting.
- Use HTTPS links (related: "The IAB encourages all web servers to
employ TLS to protect their content, and use OCSP stapling to improve
the efficiency and privacy of revocation checking." [0].
- Add VERSION_CODENAME

[0]: https://www.iab.org/documents/correspondence-reports-documents/2017-2/iab-statement-on-ocsp-stapling/
@mention-bot
Copy link
Copy Markdown

@primeos, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @oxij and @obadz to be potential reviewers.

primeos added a commit to primeos/nixpkgs that referenced this pull request Feb 25, 2017
Copy link
Copy Markdown
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@copumpkin
Copy link
Copy Markdown
Member

Sweet, thanks!

@copumpkin copumpkin merged commit 2f36be3 into NixOS:master Feb 26, 2017
@nbp nbp mentioned this pull request Feb 26, 2017
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants