Merged
Conversation
Mindavi
approved these changes
Mar 25, 2023
Member
|
For gupnp and gssdp, see #221308 |
a080cb2 to
9d0a433
Compare
13 tasks
c31ac12 to
29010f4
Compare
uninsane
reviewed
Mar 27, 2023
Contributor
There was a problem hiding this comment.
alternative to hardcoding iconv-detect.h you can invoke the emulator:
"$CC" ./iconv-detect.c -o iconv-detect
${stdenv.hostPlatform.emulator buildPackages} ./iconv-detect
rm iconv-detect
i think this would save you from adding platform-specific (musl-specific) logic.
Member
Author
There was a problem hiding this comment.
there's no special emulator for musl so it won't work
Member
There was a problem hiding this comment.
Can't we make it so that if stdenv.buildPlatform.canExecute stdenv.hostPlatform, the dummy emulator (shell) is called.
b857a43 to
479f4a8
Compare
fix cross cogl propagates gobject-introspection to buildInputs so thats why it has been working so far checked with diffing
fix cross checked with diffing
fix cross checked with diffing
fix cross checked with diffing
fix cross checked with diffing
fix cross checked with diffing
fix cross checked with diffing
NickCao
reviewed
Apr 2, 2023
uninsane
added a commit
to uninsane/nixpkgs
that referenced
this pull request
Apr 7, 2023
librest_1_0 supports cross compilation (in staging: NixOS#223142), but the old 0.8 version still doesn't. unlike 1.0 -- which builds with meson -- librest 0.8 uses autotools with no obvious way to tell `configure` to use the native gtk-doc, so just skip docs for cross builds of this older version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix cross
checked with diffing###### Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)