Skip to content

Fix editorconfig action#218853

Closed
figsoda wants to merge 4 commits intoNixOS:masterfrom
figsoda:ec
Closed

Fix editorconfig action#218853
figsoda wants to merge 4 commits intoNixOS:masterfrom
figsoda:ec

Conversation

@figsoda
Copy link
Copy Markdown
Member

@figsoda figsoda commented Feb 28, 2023 •
edited
Loading

Description of changes

Draft because I need to revert the last 2 commits. This is ready for review

second attempt (previous) at fixing this, also updates editorconfig-checker to 2.7.0

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@figsoda figsoda requested review from a team, Mic92 and zowoq as code owners February 28, 2023 18:52
@figsoda figsoda marked this pull request as draft February 28, 2023 18:52
@github-actions github-actions bot added the 6.topic: policy discussion Discuss policies to work in and around Nixpkgs label Feb 28, 2023
@drupol
Copy link
Copy Markdown
Contributor

drupol commented Feb 28, 2023

Hey,

Just chiming here... we also had issue with that action lately (see fossar/nix-phps#211)

Idea: How about switching to prettier instead of the Github Action (example: https://github.com/loophp/collection/blob/master/.github/workflows/prettier.yml) WDYT ?

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 28, 2023
@figsoda
Copy link
Copy Markdown
Member Author

figsoda commented Feb 28, 2023

it probably had something to do with nix-env instead, I'm not sure if this breakage is enough to warrant a change in the tool we are using

mweinelt
mweinelt reviewed Feb 28, 2023
View reviewed changes
pkgs/tools/nix/nix-init/default.nix
, spdx-license-list-data
}:

Copy link
Copy Markdown
Member

@mweinelt mweinelt Feb 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Probably a test to change if it reports errors? :D

Copy link
Copy Markdown
Member Author

@figsoda figsoda Feb 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last 2 commits are there to test the action, I can revert them once this is approved

@cole-h cole-h mentioned this pull request Feb 28, 2023
Merged
12 tasks
@cole-h
Copy link
Copy Markdown
Member

cole-h commented Feb 28, 2023

I think this is the "right" solution for now: #218858

We can chase the actual issue upstream (namely, ~/.nix-profile/bin not existing in $PATH).

@figsoda figsoda closed this Feb 28, 2023
@figsoda figsoda deleted the ec branch February 28, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mweinelt mweinelt mweinelt left review comments

@Mic92 Mic92 Awaiting requested review from Mic92

@zowoq zowoq Awaiting requested review from zowoq

Assignees

No one assigned

Labels

6.topic: policy discussion Discuss policies to work in and around Nixpkgs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@figsoda @drupol @cole-h @mweinelt