Skip to content

ci/editorconfig: Update the action to HEAD#211

Merged
drupol merged 1 commit intomasterfrom
editorconfig-fix
Feb 17, 2023
Merged

ci/editorconfig: Update the action to HEAD#211
drupol merged 1 commit intomasterfrom
editorconfig-fix

Conversation

@jtojnar
Copy link
Copy Markdown
Member

@jtojnar jtojnar commented Feb 14, 2023

The action recently started checking .git/config, causing the workflow to fail.
This is likely caused by the recent bump of editorconfig’s Docker image from 2.4.0 to 2.7.0.

Curiously, the issue does not occur when using 2.7.0 via the action from the main branch so let’s switch to that, pinning the commit since there is no tag yet.
While at it, let’s also pin the editorconfig version to reduce the change of possible breakage in the future.

@jtojnar jtojnar force-pushed the editorconfig-fix branch 3 times, most recently from 76b92a9 to 4a37b19 Compare February 14, 2023 16:10
@drupol
Copy link
Copy Markdown
Collaborator

drupol commented Feb 14, 2023

Wouldn't it be better to use the latest version but configure it properly ?

@jtojnar
Copy link
Copy Markdown
Member Author

jtojnar commented Feb 14, 2023

I think this is a bug in the linter so I am trying to debug it.

@drupol
Copy link
Copy Markdown
Collaborator

drupol commented Feb 16, 2023

How it's going here ?

@jtojnar jtojnar force-pushed the editorconfig-fix branch 2 times, most recently from 025c937 to 0d9bc5e Compare February 17, 2023 00:21
The action recently started checking `.git/config`, causing the workflow to fail.
This is likely caused by the recent bump of editorconfig’s Docker image from 2.4.0 to 2.7.0.

Curiously, the issue does not occur when using 2.7.0 via the action from the main branch so let’s switch to that, pinning the commit since there is no tag yet.
While at it, let’s also pin the editorconfig version to reduce the change of possible breakage in the future.
@jtojnar jtojnar changed the title ci/editorconfig: Do not check .git ci/editorconfig: Update the action to HEAD Feb 17, 2023
@jtojnar jtojnar marked this pull request as ready for review February 17, 2023 00:28
@jtojnar
Copy link
Copy Markdown
Member Author

jtojnar commented Feb 17, 2023

I did not have time for deeper diagnosis but updating the action to HEAD seems to fix it as well.

@drupol drupol merged commit 2d5d606 into master Feb 17, 2023
@drupol drupol deleted the editorconfig-fix branch February 17, 2023 04:00
@drupol drupol mentioned this pull request Feb 17, 2023
1 task
@drupol drupol mentioned this pull request Feb 28, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants