Skip to content

nixos/x11: default to the modesetting driver#218437

Merged
K900 merged 1 commit intoNixOS:masterfrom
K900:x11-default-modesetting
Mar 1, 2023
Merged

nixos/x11: default to the modesetting driver#218437
K900 merged 1 commit intoNixOS:masterfrom
K900:x11-default-modesetting

Conversation

@K900
Copy link
Copy Markdown
Contributor

@K900 K900 commented Feb 26, 2023

The upstream drivers are very dead:

Modesetting isn't even the future, it's the now, especially with Wayland. We should embrace it.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

The upstream drivers are very dead:
- nouveau:
   - https://gitlab.freedesktop.org/xorg/driver/xf86-video-nouveau/-/commits/master
   - last meaningful change in August 2020
- ati (aka radeon):
   - https://gitlab.freedesktop.org/xorg/driver/xf86-video-ati/-/commits/master
   - last meaningful change in April 2020
- amdgpu:
   - https://gitlab.freedesktop.org/xorg/driver/xf86-video-amdgpu/-/commits/master
   - barely alive, mostly thanks to Valve people

Modesetting isn't even the future, it's the now, especially with Wayland.
We should embrace it.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 26, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 26, 2023
@vcunat
Copy link
Copy Markdown
Member

vcunat commented Feb 26, 2023

I don't really know about nuances. Maybe in some cases there's a reason why people might prefer the "older" ones, but those can always choose explicitly.

When I experimented with intel settings last year, I was unable to avoid tearing with the modesetting driver and therefore switched to intel. (but this PR changes nothing around Intel GPUs anyway)

@Kranzes
Copy link
Copy Markdown
Member

Kranzes commented Feb 27, 2023

I had similar experience with tearing on intel. My only option was using a compositor which I don't want so I switches back to intel and used TearFree.

[upstream's release notes](https://github.com/iputils/iputils/releases/tag/20221126)
for more details and available replacements.

- [services.xserver.videoDrivers](options.html#opt-services.xserver.videoDrivers) now defaults to the `modesetting` driver over device-specific ones. The `radeon`, `amdgpu` and `nouveau` drivers are still available, but effectively unmaintained and not recommended for use.
Copy link
Copy Markdown
Member

@samueldr samueldr Feb 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

effectively unmaintained and not recommended for use

Is this your opinion, or is there upstream verbiage along those lines?

(Not that there is anything wrong with it, but if there are, it puts weight behind the statement.)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find direct statements from upstreams saying "don't use this", but upstreams have also all but disappeared.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find direct statements from upstreams saying "don't use this", but upstreams have also all but disappeared.

nouveau just got updated in linux 6.2 and is expected to receive substantial updates in autumn/winter.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the kernel bits, not the DDX.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the kernel bits, not the DDX.

I see, sorry.

@K900 K900 mentioned this pull request Feb 27, 2023
13 tasks
@K900 K900 merged commit 1e00e82 into NixOS:master Mar 1, 2023
@nixos-discourse
Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/amdgpu-driver-issues-after-upgrade/26252/3

@nixos-discourse
Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/amd-gpu-optimal-settings/27648/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants