Merged
Conversation
|
@primeos, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DamienCassou, @matthiasbeyer and @pSub to be potential reviewers. |
17daa3e to
02c7ed1
Compare
9434eb8 to
32ff5ab
Compare
4bfebf4 to
6b2640c
Compare
d24d9e8 to
094dd2b
Compare
4 tasks
37f1fcd to
3689c5b
Compare
Additional tools: - gpg-key2latex - gpgdir - gpgwrap This module is really hacky and the dependencies are very messy... :o However I tried my best at testing all 19 individual tools and they should (hopefully) all work now (apart from sendmail which can be provided by multiple packages) :) The code is very redundant (sorry) but imho it's easier to read and maintain it that way. TODO: There are some additional manual pages that could be included (I'm too exhausted for that atm...). And there might be a lot of stuff that could be improved in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
signing-party(pgp-tools) package (2.2 -> 2.5)I'd like to get some feedback 😄 E. g. I'm not sure if we should move bigger projects like
caffinto a separate project or just use "USE flags" (Nix expressions) for this (I'd personally prefer the later while the former might be easier for some users (but more difficult to maintain)).Please note that this isn't ready to be merged yet (or at least shouldn't be merged without further testing).
[2017-01-06: Some runtime dependencies might be missing and I should probably use something like map for the post-install part - I'll have a closer look later...]
Imho this package (upsteam) seems like a big mess (it's an awesome project but it contains many different programs/binaries and most Makefiles only provide a dummy install target for some reason...).
I'll try to improve the upstream sources after finishing this PR.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)Building this requires
libmdfrom #21503 (already merged in master).