Skip to content

libmd: init at 0.0.0#21503

Merged
joachifm merged 1 commit intoNixOS:masterfrom
primeos:libmd
Dec 30, 2016
Merged

libmd: init at 0.0.0#21503
joachifm merged 1 commit intoNixOS:masterfrom
primeos:libmd

Conversation

@primeos
Copy link
Copy Markdown
Member

@primeos primeos commented Dec 29, 2016

Motivation for this change

I'll update the signing-party package from version 2.2 to 2.5 which requires this library as a build dependency.

The licenses are a bit messy... I'm not entirely sure if I added them correctly, please have a close look - thx :) - All licenses are specified in COPYING.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux (Gentoo+Nix)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link
Copy Markdown

@primeos, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vcunat, @edolstra and @Fuuzetsu to be potential reviewers.

@primeos primeos force-pushed the libmd branch 2 times, most recently from 1c495d7 to 00587e8 Compare December 29, 2016 20:09
@joachifm
Copy link
Copy Markdown
Contributor

Since you asked about the licenses: It's unclear to me how the Aaron D. Gifford 3-clause BSD differs except for the name of the copyright holder. As such, I believe it is sufficient to just label it as bsd3. I also wonder how NetBSD 2-clause BSD differs from bsd2; can you elaborate?

@primeos
Copy link
Copy Markdown
Member Author

primeos commented Dec 29, 2016

Since you asked about the licenses: It's unclear to me how the Aaron D. Gifford 3-clause BSD differs except for the name of the copyright holder.

@joachifm Yes they seem identical but (sadly :D) they aren't. A quick diff is probably best suited to show the differences:

#diff bsd3 bsd3-aaron-d-gifford                                                                                                                                                        /tmp/license
9,10c9,11
<  3. The name of the author may not be used to endorse or promote products
<     derived from this software without specific prior written permission.
---
>  3. Neither the name of the copyright holder nor the names of contributors
>     may be used to endorse or promote products derived from this software
>     without specific prior written permission.
12,21c13,23
<  THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES,
<  INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY
<  AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL
<  THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
<  EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
<  PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
<  OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
<  WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
<  OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
<  ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
---
>  THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTOR(S) ``AS IS'' AND
>  ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
>  IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
>  ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTOR(S) BE LIABLE
>  FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
>  DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
>  OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
>  HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
>  LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
>  OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
>  SUCH DAMAGE.
#diff bsd2 bsd2-netbsd                                                                                                                                                                 /tmp/license
10,19c10,20
<  THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
<  IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
<  OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
<  IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
<  INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
<  NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
<  DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
<  THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
<  (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
<  THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
---
>  THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
>  ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
>  TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>  PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
>  BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>  CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>  SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>  INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>  CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
>  POSSIBILITY OF SUCH DAMAGE.

As such, I believe it is sufficient to just label it as bsd3. I also wonder how NetBSD 2-clause BSD differs from bsd2; can you elaborate?

I'm not into this license stuff at all, so I don't know if they're similar enough to simply ignore them. I just assumed I'll have to include them as soon as they're not exactly identical.

@joachifm
Copy link
Copy Markdown
Contributor

joachifm commented Dec 29, 2016

I think that, for our purposes, it's the terms & conditions that matter. As far as I can tell, the terms are the same here. Whether the verbiage refers to "the author", "the copyright holder and contributors", or "the NetBSD foundation" seems irrelevant to me. Are there any substantive differences I've missed?

@primeos
Copy link
Copy Markdown
Member Author

primeos commented Dec 30, 2016

I think that, for our purposes, it's the terms & conditions that matter. As far as I can tell, the terms are the same here. Whether the verbiage refers to "the author", "the copyright holder and contributors", or "the NetBSD foundation" seems irrelevant to me.

ok, sounds reasonable - I removed them, thx 😄

Are there any substantive differences I've missed?

No, I don't think so.

@primeos primeos mentioned this pull request Dec 30, 2016
7 tasks
@joachifm
Copy link
Copy Markdown
Contributor

Is it feasible to use the release tarball(s) https://archive.hadrons.org/software/libmd/?

@primeos
Copy link
Copy Markdown
Member Author

primeos commented Dec 30, 2016

Is it feasible to use the release tarball(s) https://archive.hadrons.org/software/libmd/?

@joachifm Yes, that should be possible, however I thought using the Git repository would be better since it allows users of this Package to specify a specific commit instead of a single release and the release from the archive could (should not but if I remember correctly some projects do such things) change. But ofc that's just my personal opinion which could be wrong - is there some sort of ranking available anywhere? Imho it would be a good idea to better document this in the manual.

@joachifm
Copy link
Copy Markdown
Contributor

There's a strong preference for using source archives that can be fetched with fetchurl; as the manual points out, it is the only one which supports caching. A user who wishes to replace src with a more recent set of sources can do so via the various override mechanisms.

@joachifm joachifm merged commit b1ac86d into NixOS:master Dec 30, 2016
@joachifm
Copy link
Copy Markdown
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants