resholve: fold in python package deps#205387
Merged
ncfavier merged 1 commit intoNixOS:masterfrom Dec 10, 2022
Merged
Conversation
Protects resholve and dependents from breakages as py27 support is removed (or rots).
Member
|
I think it might be a better idea to just not remove the dependencies at all |
Member
Author
|
I think that's debatable on its own merits, but typing has already been removed and a testing change has broken configargparse on python27. |
figsoda
approved these changes
Dec 10, 2022
Contributor
|
|
ncfavier
approved these changes
Dec 10, 2022
Closed
SamLukeYes
added a commit
to SamLukeYes/nixos
that referenced
this pull request
Dec 11, 2022
27 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Pull some python package expressions in to resholve's deps to protect it and dependents from breakages as py27 support is removed (or rots) across the python package set.
Result of
nixpkgs-reviewrun on x86_64-darwin 113 packages built:
Result of
nixpkgs-review pr 205387run on x86_64-linux 115 packages built:
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notescc @bobrik