Skip to content

subsurface: libsForQt514 -> libsForQt5#204250

Merged
K900 merged 1 commit intoNixOS:masterfrom
qowoz:fix-eval
Dec 3, 2022
Merged

subsurface: libsForQt514 -> libsForQt5#204250
K900 merged 1 commit intoNixOS:masterfrom
qowoz:fix-eval

Conversation

@zowoq
Copy link
Copy Markdown
Contributor

@zowoq zowoq commented Dec 3, 2022

Description of changes

fix eval

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@zowoq zowoq added the 1.severity: channel blocker Blocks a channel label Dec 3, 2022
@vcunat
Copy link
Copy Markdown
Member

vcunat commented Dec 3, 2022

This reverts unintentional change in 29db827 (PR #202465).

The tarball job then got broken by interaction with PR #202661
https://hydra.nixos.org/build/200505975

This was referenced Dec 3, 2022
Merged
Merged
@K900 K900 merged commit 49b8ad6 into NixOS:master Dec 3, 2022
@zowoq zowoq deleted the fix-eval branch December 3, 2022 09:04
@vcunat
Copy link
Copy Markdown
Member

vcunat commented Dec 3, 2022

I now verified locally:

nix build -f pkgs/top-level/release.nix tarball

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

1.severity: channel blocker Blocks a channel 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zowoq @vcunat @K900