Skip to content

treewide: drop Qt5 < 5.15#202661

Merged
K900 merged 3 commits intoNixOS:masterfrom
K900:goodbye-my-qt-goodbye
Dec 3, 2022
Merged

treewide: drop Qt5 < 5.15#202661
K900 merged 3 commits intoNixOS:masterfrom
K900:goodbye-my-qt-goodbye

Conversation

@K900
Copy link
Copy Markdown
Contributor

@K900 K900 commented Nov 24, 2022 •
edited
Loading

Description of changes

Closes #201765.

I fully intend to merge this in the coming days unless there are any major objections.

List of affected packages:

Package Dead upstream Notes Maintainer pings
airwave ? unconfirmed, can't find a way to obtain required source @michalrus
boomerang very @dtzWill
foxitreader ? can't fetch the source, package hasn't been updated for over a year @p-h @rhoriguchi
kexi basically @zraexy
olive-editor ? upstream is active, but last numbered release in 2019 - update to unstable? @balsoft
pulseview ? deadness of upstream needs confirmation @bjornfor
quiterss yes builds on 5.15 but segfaults on startup (might be Wayland specific?) @primeos
swift-im very @orivej
tony very @orivej
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: qt/kde Object-oriented framework for GUI creation label Nov 24, 2022
@K900 K900 changed the title Goodbye my qt goodbye [DO NOT MERGE] Drop Qt5 < 5.15 Nov 24, 2022
@K900

This comment was marked as outdated.

Sign in to view
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Nov 24, 2022
@K900
Copy link
Copy Markdown
Contributor Author

K900 commented Nov 24, 2022

Result of nixpkgs-review pr 202661 run on x86_64-linux 1

15 packages failed to build:
  • bitcoin-classic
  • bitcoin-gold
  • boomerang
  • digibyte
  • foxitreader
  • graphia
  • kexi
  • mythtv
  • odoo
  • olive-editor
  • pulseview
  • swift-im
  • tony
  • vertcoin
  • xygrib
11 packages built:
  • apmplanner2
  • bitcoin-unlimited
  • brewtarget
  • cb2bib
  • common-updater-scripts
  • digitalbitbox
  • fontmatrix
  • ipe
  • quiterss
  • rosegarden
  • wkhtmltopdf

@K900
Copy link
Copy Markdown
Contributor Author

K900 commented Nov 24, 2022

Updated including broken/insecure/unfree packages.

@K900 K900 force-pushed the goodbye-my-qt-goodbye branch 3 times, most recently from c6897b4 to 7b31213 Compare November 28, 2022 08:03
@K900 K900 marked this pull request as ready for review November 28, 2022 09:04
@K900 K900 requested review from ttuegel as code owners November 28, 2022 09:04
@K900 K900 changed the title [DO NOT MERGE] Drop Qt5 < 5.15 treewide: drop Qt5 < 5.15 Nov 28, 2022
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation labels Nov 28, 2022
@K900 K900 mentioned this pull request Nov 28, 2022
Closed
31 tasks
@K900 K900 self-assigned this Nov 28, 2022
@K900
Copy link
Copy Markdown
Contributor Author

K900 commented Nov 28, 2022

Also, I will flag everything that FTBFS right before merging the PR. Not doing it now to simplify potential fix merges.

SuperSandro2000
SuperSandro2000 reviewed Nov 28, 2022
View reviewed changes
@K900 K900 force-pushed the goodbye-my-qt-goodbye branch from db90e70 to 8d27f4f Compare November 29, 2022 06:35
@rhoriguchi
Copy link
Copy Markdown
Contributor

rhoriguchi commented Nov 29, 2022

Foxitreader is dead, there's not even a download link listed on their web page. Package download link and package still work.

@K900 K900 force-pushed the goodbye-my-qt-goodbye branch from 8d27f4f to 7348354 Compare December 3, 2022 07:51
@K900 K900 merged commit 3ee2fd4 into NixOS:master Dec 3, 2022
@K900
Copy link
Copy Markdown
Contributor Author

K900 commented Dec 3, 2022

Let's go.

@vcunat vcunat mentioned this pull request Dec 3, 2022
Merged
13 tasks
@zowoq
Copy link
Copy Markdown
Contributor

zowoq commented Dec 3, 2022 •
edited
Loading

It was caused by a mistake in another PR (#202465 (comment)) but should have waited for CI to finish after the force-push as it would have shown that merging this would break eval.

#204250

@K900
Copy link
Copy Markdown
Contributor Author

K900 commented Dec 3, 2022

That's what I get for trusting git too much, I guess. Thanks for the fix!

@meck
Copy link
Copy Markdown
Contributor

meck commented Dec 7, 2022

Pulseview repo master branch at git://sigrok.org/pulseview.git has some commits for enabling building with qt6, i havent had time to test @bjornfor

@K900 K900 deleted the goodbye-my-qt-goodbye branch July 27, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@balsoft balsoft balsoft approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel

+1 more reviewer

@rhoriguchi rhoriguchi rhoriguchi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@K900 K900

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde Object-oriented framework for GUI creation 8.has: changelog This PR adds or changes release notes 8.has: clean-up This PR removes packages or removes other cruft 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop Qt 5.12 and 5.14

7 participants

@K900 @rhoriguchi @zowoq @meck @thiagokokada @SuperSandro2000 @balsoft