Merged
Conversation
Co-authored-by: zero_one <zero_one_01@outlook.de> Co-authored-by: Anthony Carrico <acarrico@memebeam.org> Co-authored-by: K900 <me@0upti.me>
31 tasks
K900
approved these changes
Nov 27, 2022
Contributor
K900
left a comment
There was a problem hiding this comment.
Diff LGTM, it... starts, at least. Can't really test much more.
Contributor
|
It works fine on x86_64-linux. |
Comment on lines
+10
to
+12
| +# if [ $target_os = "linux" ] ; then | ||
| +# . /etc/os-release | ||
| +# fi |
Member
There was a problem hiding this comment.
This should just be removed instead of commented out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
MythTV version bump, drawing from #197930 and K900's patch
I do not actually use this software myself and only care as it relates to dropping old Qt5 versions. I only confirmed that it builds (x86_64-linux and aarch64-linux), so if someone who actually uses this software could test it that would be very helpful
Related to dropping Qt 5.14: #201765
cc: @acarrico @zero-one01 @K900
Supersedes and closes #197930
Closes #190082
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notesnixpkgs-review
Result of
nixpkgs-review pr 203145run on x86_64-linux 11 package built:
Result of
nixpkgs-review pr 203145run on aarch64-linux 11 package built: