qt5/qtwayland: fix popups being placed outside the screen#200872
Merged
lovesegfault merged 1 commit intoNixOS:stagingfrom Nov 12, 2022
Merged
qt5/qtwayland: fix popups being placed outside the screen#200872lovesegfault merged 1 commit intoNixOS:stagingfrom
lovesegfault merged 1 commit intoNixOS:stagingfrom
Conversation
QT 5 did not set layout constraints on their popups. This causes some compositors like GNOME to place the popups partially outside the screen. This change backports the corresponding fix, but with an exclusion for KDE as its current version does not work well with layout constraints.
92966ef to
fd94629
Compare
vcunat
added a commit
that referenced
this pull request
Nov 17, 2022
...into staging-next. Also merged topologically later in 6a01be6.
Contributor
|
This regressed 5.12/5.14, which we still have in a few places. |
vcunat
added a commit
that referenced
this pull request
Nov 18, 2022
/cc the PR adding this patch: #200872
Member
|
OK, applied conditionally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
QT 5 did not set layout constraints on their popups. This causes some compositors like GNOME to place the popups partially outside the screen. This change backports the corresponding fix, but with an exclusion for KDE as its current version does not work well with layout constraints.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes