Skip to content

node-packages: update & cleanup#19980

Merged
NeQuissimus merged 4 commits intoNixOS:masterfrom
cko:cleanup_node_packages
Nov 1, 2016
Merged

node-packages: update & cleanup#19980
NeQuissimus merged 4 commits intoNixOS:masterfrom
cko:cleanup_node_packages

Conversation

@cko
Copy link
Copy Markdown
Member

@cko cko commented Oct 29, 2016

  • update packages for v4
  • remove files and generation for v0_10 and v5 packages as nodejs-5_x and nodejs-0_10 are no longer supported

(also discussed in #19966)

cko added 3 commits October 29, 2016 23:08
* update packages for v4
* remove files and generation for v0_10 and v5 as nodejs-5_x and nodejs-0_10 are no longer supported
@vcunat
Copy link
Copy Markdown
Member

vcunat commented Oct 30, 2016

Nitpick: in pkgs/development/node-packages/node-env.nix you seem to be just adding spaces to empty lines.

@gilligan
Copy link
Copy Markdown
Contributor

We were discussing switching the nodejs default version from v4 to v6 - maybe you want to add this to this PR? Then i can close #19966

@cko
Copy link
Copy Markdown
Member Author

cko commented Oct 30, 2016

@gilligan [x] done
@vcunat this file is generated and I didn't want to touch it manually

@NeQuissimus NeQuissimus merged commit dc04a8e into NixOS:master Nov 1, 2016
@gilligan
Copy link
Copy Markdown
Contributor

gilligan commented Nov 2, 2016

@cko This PR updated nodejs to export nodejs-6 but nodePackages is still set to nodePackages_4_x;!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants