Skip to content

RFC: drop nodejs-4_x and packages#19966

Closed
gilligan wants to merge 1 commit intoNixOS:masterfrom
holidaycheck:nodejs-drop-v4
Closed

RFC: drop nodejs-4_x and packages#19966
gilligan wants to merge 1 commit intoNixOS:masterfrom
holidaycheck:nodejs-drop-v4

Conversation

@gilligan
Copy link
Copy Markdown
Contributor

@gilligan gilligan commented Oct 29, 2016

Motivation for this change

Currently we are still maintaining versions 0.10, 4_x and 6_x. Since October 6_x is the active LTS release. I see no good reason to keep maintaining 4.x (See LTS Schedule). As for 0.10 that might be of use for some legacy projects I suppose.

What are your thoughts on this @svanderburg and @LnL7 ?

I also need some help with this PR. I think pkgs/development/node-packages/* needs some work. The generate script was still referring to non-existing v5 packages and the v0.10 refers to v4 composition files. The generation for 6.x is missing entirely.

Can you help me out with that @svanderburg ?

@vcunat vcunat added 8.has: clean-up This PR removes packages or removes other cruft 9.needs: community feedback This needs feedback from more community members. labels Oct 29, 2016
@NeQuissimus
Copy link
Copy Markdown
Member

NeQuissimus commented Oct 29, 2016

0.10 was removed in #19665
Are there leftovers?

@svanderburg
Copy link
Copy Markdown
Member

svanderburg commented Oct 29, 2016

Not that I have any personal objections, but my employer still relies on
having Node.js 4.x available.

Perhaps, since Node js 6.x is the new LTS release, we should make this the
default version. I believe atm Node.js 4.x is still the default.

On Sat, Oct 29, 2016 at 4:19 PM, Tim Steinbach notifications@github.com
wrote:

0.10 was removed in #19665 #19665
Are there leftovers?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#19966 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABGY9yEwZxUh8scv6puNNz9SE8F1NjGkks5q41XZgaJpZM4KkEaN
.

@gilligan
Copy link
Copy Markdown
Contributor Author

gilligan commented Oct 29, 2016

@svanderburg alright - so lets keep 4.x around and set 6.x as default version exposed by nodejs. Can you update that generate shell script to generate packages for 6.x ?

@gilligan
Copy link
Copy Markdown
Contributor Author

gilligan commented Oct 29, 2016

@NeQuissimus ooops- you are absolutely right of course - nodejs 0.10 is gone already. My bad ;)

@cko cko mentioned this pull request Oct 29, 2016
Merged
@gilligan
Copy link
Copy Markdown
Contributor Author

gilligan commented Oct 30, 2016

This will be solved by #19980

@gilligan gilligan closed this Oct 30, 2016
@gilligan gilligan deleted the nodejs-drop-v4 branch October 30, 2016 16:29
@nbp nbp mentioned this pull request Feb 26, 2017
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 9.needs: community feedback This needs feedback from more community members.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gilligan @NeQuissimus @svanderburg @vcunat