Skip to content

platformio: work around fallout from #194205#199027

Merged
mweinelt merged 2 commits intoNixOS:masterfrom
arcnmx:platformio-fix
Nov 8, 2022
Merged

platformio: work around fallout from #194205#199027
mweinelt merged 2 commits intoNixOS:masterfrom
arcnmx:platformio-fix

Conversation

@arcnmx
Copy link
Copy Markdown
Member

@arcnmx arcnmx commented Nov 1, 2022

fixes #198319

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Nov 1, 2022
@ofborg ofborg bot requested a review from mogorman November 1, 2022 19:09
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 1, 2022
@arcnmx arcnmx requested review from FRidh and makefu November 1, 2022 19:32
@arcnmx arcnmx mentioned this pull request Nov 1, 2022
Merged
13 tasks
@qaristote qaristote mentioned this pull request Nov 3, 2022
Closed
@gador
Copy link
Copy Markdown
Member

gador commented Nov 4, 2022

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 199027 run on x86_64-linux 1

2 packages built:
  • esphome
  • platformio

@elohmeier
Copy link
Copy Markdown
Contributor

elohmeier commented Nov 7, 2022

Built & tested successfully on aarch64-linux. You could also remove the broken = stdenv.isAarch64 again which was accidentally re-added to core.nix (see #182042).

@MrTarantoga
Copy link
Copy Markdown
Contributor

MrTarantoga commented Nov 7, 2022

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 199027 run on x86_64-linux 1
2 packages built:

Also tested and works as it should. Great job!

@elohmeier
Copy link
Copy Markdown
Contributor

elohmeier commented Nov 8, 2022

Also relevant for ZHF: #199919

@mweinelt mweinelt merged commit d1fb88d into NixOS:master Nov 8, 2022
@arcnmx arcnmx deleted the platformio-fix branch November 8, 2022 15:00
@makefu
Copy link
Copy Markdown
Contributor

makefu commented Nov 8, 2022

Hey @arcnmx , just wanted to say thanks for fixing this package, i really appreciate i!
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mogorman mogorman Awaiting requested review from mogorman

@makefu makefu Awaiting requested review from makefu

@FRidh FRidh Awaiting requested review from FRidh

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

platformio: fails to build on nixos-unstable

6 participants

@arcnmx @gador @elohmeier @MrTarantoga @makefu @mweinelt