Skip to content

platformio: unset broken on aarch64#182042

Merged
peterhoeg merged 1 commit intoNixOS:masterfrom
elohmeier:platformio-unbreak
Jul 19, 2022
Merged

platformio: unset broken on aarch64#182042
peterhoeg merged 1 commit intoNixOS:masterfrom
elohmeier:platformio-unbreak

Conversation

@elohmeier
Copy link
Copy Markdown
Contributor

Description of changes

platformio has been marked as broken in #49460 as of version 3.6.1. I've noticed that it builds and works fine as of the current version 6.0.1 in nixpkgs on aarch64-linux.

Things done

Removed the broken attribute from platformio meta.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 19, 2022
@peterhoeg
Copy link
Copy Markdown
Member

I have no way of testing this, so if you say it's good, let's get this going!

@github-actions
Copy link
Copy Markdown
Contributor

Successfully created backport PR #182074 for release-22.05.

@elohmeier elohmeier deleted the platformio-unbreak branch July 19, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants