Merged
Conversation
Since 9f309c8 ("stdenv: mesonFlags: use canExecute in needs_exe_wrapper"), glib's tests are built (but not run by default) in pkgsStatic. This broke the build because some of the tests required shared libraries. This patch (which is awaiting review upstream) disables building those libraries and any tests that depend on them in a static-only build.
Member
|
The patch looks good, in my opinion |
Ma27
approved these changes
Sep 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Since #183507, glib's tests are built (but not run by default) in pkgsStatic. This broke the build because some of the tests required shared libraries. This patch (which is awaiting review upstream) disables building those libraries and any tests that depend on them in a static-only build.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes