stdenv: mesonFlags: specify more targetPrefix'd binaries#183507
Merged
SuperSandro2000 merged 3 commits intoNixOS:stagingfrom Aug 1, 2022
Merged
stdenv: mesonFlags: specify more targetPrefix'd binaries#183507SuperSandro2000 merged 3 commits intoNixOS:stagingfrom
SuperSandro2000 merged 3 commits intoNixOS:stagingfrom
Conversation
13 tasks
Member
|
Can you please explain in the commit message what the purpose of this change is? "improve" isn't really enough information. I can try to infer the context from the linked PR but would be much better to have it properly explained in the commit message. |
alyssais
reviewed
Jul 28, 2022
Member
Author
|
TODO: investigate using the env vars we already set by adding entries to |
Member
Author
Member
|
The commit message is fantastic now, thank you! :) (And thanks for going upstream!) |
meson did not use these
therefore some packages had to do things
like this
```
substituteInPlace meson.build --replace \
"find_program('nm')" \
"find_program('${stdenv.cc.targetPrefix}nm')"
```
they are unnecessary since 32e36bd429f804fd1468f51e39020f7360d8a5a8 NixOS#183507
this is more accurate
Ericson2314
approved these changes
Aug 1, 2022
Member
Ericson2314
left a comment
There was a problem hiding this comment.
This is really great! Great job!!
Member
|
9f309c8 ("stdenv: mesonFlags: use canExecute in needs_exe_wrapper") broke |
Member
|
Ah, because now glib builds its tests, and lots of those tests involve building shared libraries. Maybe I can get them to disable the tests if default_library=static. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see commit msgs
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes