Skip to content

treewide: pin failing packages to openssl_1_1#190667

Merged
vcunat merged 46 commits intoNixOS:staging-nextfrom
anthonyroussel:pin-openssl
Sep 12, 2022
Merged

treewide: pin failing packages to openssl_1_1#190667
vcunat merged 46 commits intoNixOS:staging-nextfrom
anthonyroussel:pin-openssl

Conversation

@anthonyroussel
Copy link
Copy Markdown
Member

@anthonyroussel anthonyroussel commented Sep 10, 2022 •
edited
Loading

Description of changes

Pin to openssl_1_1 the following packages on staging-next PR:

  • perl534Packages.ZonemasterLDNS
  • movine
  • kore
  • journaldriver
  • espanso
  • cfdyndns
  • cargo-raze
  • cargo-dephell
  • cargo-bisect-rustc
  • break-time
  • bip
  • archiveopteryx
  • hadoop
  • mrustc-bootstrap
  • nfd
  • sslsplit
  • tremor-rs
  • tensorman
  • taizen
  • synapse-bt
  • spotify-tui
  • ndn-tools
  • ndn-cxx
  • shticker-book-unwritten
  • rucredstash
  • quill
  • netease-music-tui
  • paperoni
  • mdbook-plantuml
  • imag
  • hydra-cli
  • hash_extender
  • habitat
  • gmnisrv
  • git-series
  • finalfrontier
  • devserver
  • cliscord
  • coinlive
  • xbps
  • eidolon
  • wkhtmltopdf-bin
  • tunnelto
  • chit

Fix the failing build in staging-next PR: #188284

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 10, 2022
@anthonyroussel anthonyroussel changed the title chit, tunnelto, wkhtmltopdf-bin, eidolon, xbps: pin to openssl_1_1 chit, tunnelto, wkhtmltopdf-bin, eidolon, xbps, coinlive: pin to openssl_1_1 Sep 10, 2022
@anthonyroussel anthonyroussel changed the title chit, tunnelto, wkhtmltopdf-bin, eidolon, xbps, coinlive: pin to openssl_1_1 chit, tunnelto, wkhtmltopdf-bin, eidolon, xbps, coinlive, cliscord: pin to openssl_1_1 Sep 10, 2022
@anthonyroussel anthonyroussel changed the title chit, tunnelto, wkhtmltopdf-bin, eidolon, xbps, coinlive, cliscord: pin to openssl_1_1 chit, tunnelto, wkhtmltopdf-bin, eidolon, xbps, coinlive, cliscord, devserver: pin to openssl_1_1 Sep 10, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 10, 2022
@ofborg ofborg bot requested a review from reedrw September 10, 2022 23:19
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Sep 10, 2022
@anthonyroussel anthonyroussel added the 0.kind: build failure A package fails to build label Sep 10, 2022
@anthonyroussel
Copy link
Copy Markdown
Member Author

anthonyroussel commented Sep 11, 2022

@ofborg build espanso

@ajs124
Copy link
Copy Markdown
Member

ajs124 commented Sep 11, 2022

I didn't think I'd missed quite that many packages… sorry. Thanks for taking care of this.

@ofborg ofborg bot requested a review from qbit September 11, 2022 00:35
@anthonyroussel
Copy link
Copy Markdown
Member Author

anthonyroussel commented Sep 11, 2022

I didn't think I'd missed quite that many packages… sorry. Thanks for taking care of this.

No problem, don't worry :)

@anthonyroussel
Copy link
Copy Markdown
Member Author

anthonyroussel commented Sep 11, 2022 •
edited
Loading

I tried to fix as many packages as possible by pinning openssl to 1.1 on the staging-next branch.

I will stop here with my PR, because there are too many packages (45).

I propose that we do a review of all this, merge, and see the result on Hydra in a few days.
What do you think?

qbit
qbit approved these changes Sep 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@qbit qbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perl534Packages.ZonemasterLDNS seems fine with this!

@ofborg ofborg bot requested a review from qbit September 11, 2022 07:05
@bobby285271 bobby285271 added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Sep 11, 2022
@ajs124
Copy link
Copy Markdown
Member

ajs124 commented Sep 11, 2022

Result of nixpkgs-review pr 190667 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • spark2
  • spark_2_4
3 packages failed to build:
  • cargo-raze
  • mrustc-bootstrap
  • tremor-rs
53 packages built:
  • archiveopteryx
  • bip
  • break-time
  • cargo-bisect-rustc
  • cargo-dephell
  • cfdyndns
  • chit
  • cliscord
  • coinlive
  • devserver
  • eidolon
  • espanso
  • finalfrontier
  • git-series
  • gmnisrv
  • habitat
  • hadoop (hadoop3 ,hadoop_3_3)
  • hash_extender
  • hydra-cli
  • imag
  • journaldriver
  • kore
  • mdbook-plantuml
  • movine
  • ndn-cxx
  • ndn-tools
  • netease-music-tui
  • nfd
  • paperoni
  • perl534Packages.ZonemasterCLI
  • perl534Packages.ZonemasterEngine
  • perl534Packages.ZonemasterLDNS
  • zonemaster-cli (perl536Packages.ZonemasterCLI)
  • perl536Packages.ZonemasterEngine
  • perl536Packages.ZonemasterLDNS
  • pig
  • python310Packages.dask-yarn
  • python310Packages.skein
  • python39Packages.dask-yarn
  • python39Packages.skein
  • quill
  • rucredstash
  • shticker-book-unwritten
  • spark (spark3 ,spark_3_2)
  • spark_3_1
  • spotify-tui
  • sslsplit
  • synapse-bt
  • taizen
  • tensorman
  • tunnelto
  • wkhtmltopdf-bin
  • xbps

@ajs124
Copy link
Copy Markdown
Member

ajs124 commented Sep 11, 2022 

diff --git a/pkgs/development/compilers/mrustc/bootstrap.nix b/pkgs/development/compilers/mrustc/bootstrap.nix
index 85b328848b1..70249fed66b 100644
--- a/pkgs/development/compilers/mrustc/bootstrap.nix
+++ b/pkgs/development/compilers/mrustc/bootstrap.nix
@@ -71,7 +71,7 @@ stdenv.mkDerivation rec {
     # for rustc
     llvm_7 libffi zlib libxml2
     # for cargo
-    openssl curl
+    openssl (curl.override { inherit openssl; })
   ];
 
   makeFlags = [

should fix mrustc-bootstrap

@anthonyroussel
Copy link
Copy Markdown
Member Author

anthonyroussel commented Sep 11, 2022

@ofborg build cargo-raze mrustc-bootstrap tremor-rs

@ofborg ofborg bot requested review from elasticdog, progval and r-burns September 11, 2022 21:36
@bobby285271 bobby285271 removed the 12.approvals: 2 This PR was reviewed and approved by two persons. label Sep 11, 2022
@vcunat vcunat changed the title chit, tunnelto, wkhtmltopdf-bin, eidolon, xbps, coinlive, cliscord, devserver: pin to openssl_1_1 treewide: pin failing packages to openssl_1_1 Sep 12, 2022
@vcunat vcunat merged commit b1d87c0 into NixOS:staging-next Sep 12, 2022
@anthonyroussel anthonyroussel deleted the pin-openssl branch September 12, 2022 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@reedrw reedrw Awaiting requested review from reedrw

@stigtsp stigtsp Awaiting requested review from stigtsp

@zakame zakame Awaiting requested review from zakame

@dasJ dasJ Awaiting requested review from dasJ

@qbit qbit Awaiting requested review from qbit

@elasticdog elasticdog Awaiting requested review from elasticdog

@r-burns r-burns Awaiting requested review from r-burns

@progval progval Awaiting requested review from progval

Assignees

No one assigned

Labels

0.kind: build failure A package fails to build 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@anthonyroussel @ajs124 @qbit @SuperSandro2000 @vcunat @bobby285271