lib/systems: uname.processor is "uname -m", not "uname -p"#189958
Merged
matthewbauer merged 1 commit intomasterfrom Sep 6, 2022
unknown repository
Merged
lib/systems: uname.processor is "uname -m", not "uname -p"#189958matthewbauer merged 1 commit intomasterfrom unknown repository
matthewbauer merged 1 commit intomasterfrom
unknown repository
Conversation
The comment in lib/systems/default.nix for uname.processor indicates that it should match `uname -p`. I tried that command and found that it reports `unknown` on all of these machines: - `x86_64-linux` - `aarch64-linux` - `mips64el-linux` - `powerpc64le-linux` The command `uname -m` reports the expected value on all of the above. I think the comment is wrong. So I fixed it.
5 tasks
Member
|
thanks |
RaitoBezarius
pushed a commit
to RaitoBezarius/nixpkgs
that referenced
this pull request
Sep 17, 2022
) The comment in lib/systems/default.nix for uname.processor indicates that it should match `uname -p`. I tried that command and found that it reports `unknown` on all of these machines: - `x86_64-linux` - `aarch64-linux` - `mips64el-linux` - `powerpc64le-linux` The command `uname -m` reports the expected value on all of the above. I think the comment is wrong. So I fixed it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The comment in lib/systems/default.nix for uname.processor indicates that it should match
uname -p. I tried that command and found that it reportsunknownon all of these machines:x86_64-linuxaarch64-linuxmips64el-linuxpowerpc64le-linuxThe command
uname -mreports the expected value on all of the above.Things done
I think the comment is wrong. So I fixed it.