mepo: gpsdSupport; don't leak user location to mozilla/geoclue without asking#189345
Conversation
…t asking This patch adds `gpsd` as an optional dependency and points mepo's scripts' `gpspipe` to the correct path. This patch also makes silent reporting of the user's location to Mozilla and geoclue opt-in rather than opt-out; this issue has been reported upstream to request a build flag so we don't have to use patches: https://todo.sr.ht/~mil/mepo-tickets/41
sikmir
reviewed
Sep 1, 2022
Co-authored-by: Nikolay Korotkiy <sikmir@disroot.org>
Member
|
GPS support was added in 0.5, please cherry pick these to GH-189344.
|
Closed
Author
|
Cherry-picked into #189344; none of the functionality described above existed before 0.5. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This patch adds
gpsdas an optional dependency and points mepo's scripts'gpspipeto the correct path.This patch also makes silent reporting of the user's location to Mozilla and geoclue opt-in rather than opt-out; this issue has been reported upstream to request a build flag so we don't have to use patches.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes