Conversation
|
Added commits which were formerly part of #189345. |
|
Path to GeoClue binaries need substitution
and IMHO Mozilla location service should be
conditionally enabled in the same manner as the others.
BTW you should rebase the commits for each to be meaningful
(GitHub suggestion should be read-only).
|
Done: 3b8d39d136de50cfd3b0e3159cb0b2b318b67565
I don't understand what you mean... isn't
I don't understand this either... what do you mean by meaningful? And what GitHub suggestion? |
It is, apologies, I misread 😅
37ceaf7d4c5c1157b3eb51262d520fc0ec0cdb77 and 3b8d39d136de50cfd3b0e3159cb0b2b318b67565 are examples of commits that only make sense with the context of the discussion. Each commit should make sense by itself should it be merged.
The one created 37ceaf7d4c5c1157b3eb51262d520fc0ec0cdb77. |
Oh, I see, you want me to squash the history to clean it up. Sure, no problem.
Right. Just to be clear though, I don't think it is a good idea to merge the version bump without the user location protection. I will squash the history into two commits, but I hope that either both of them or else neither of them is merged. |
|
Thanks! GitHub UX kinda only allows merging all or nothing
(unless a maintainer pushes to your remote which is too spooky IMHO),
hence often quite some nitpick round trips are needed.
|
mepo 0.5 silently reports the user's location to Mozilla without asking first. Let's disable this by default. This has been reported to upstream with a request for a build-time flag so we can drop the patch: https://todo.sr.ht/~mil/mepo-tickets/41
Ah, interesting; I did not know that. I have plenty of complaints about github :)
No problem. Should be squashed now into four separate topic-specific commits at 8981daa. This should make things easier down the line if one of them needs to be reverted. |
|
Result of 2 packages built:
|
|
I guess .orig file should not be installed: |
| , geoclueSupport ? false , geoclue2 | ||
|
|
||
| # transmits user's location without asking first | ||
| , reportLocationToMozilla ? false | ||
|
|
||
| , gpsdSupport ? true , gpsd |
There was a problem hiding this comment.
| , geoclueSupport ? false , geoclue2 | |
| # transmits user's location without asking first | |
| , reportLocationToMozilla ? false | |
| , gpsdSupport ? true , gpsd | |
| , geoclueSupport ? false, geoclue2 | |
| # transmits user's location without asking first | |
| , reportLocationToMozilla ? false | |
| , gpsdSupport ? true, gpsd |
Shouldn't we assert something here? not sure what tbh
There was a problem hiding this comment.
Shouldn't we assert something here?
Why?
There was a problem hiding this comment.
Would it work to turn all on or off?
There was a problem hiding this comment.
Correct: all 2^3 combinations of the three boolean flags are valid.
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
I'm trying to reproduce this. We might need |
Description of changes
First commit is a simple version bump.
Second commit adds
gpsdas an optional dependency and points mepo's scripts'gpspipeto the correct path. It also makes silent reporting of the user's location to Mozilla and geoclue opt-in rather than opt-out; this issue has been reported upstream to request a build flag so we don't have to use patches.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes