Skip to content

stdenv: extendMkDerivationArgs: support mkDerivation (_: ...) from #119942#185077

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

stdenv: extendMkDerivationArgs: support mkDerivation (_: ...) from #119942#185077
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Aug 4, 2022 •
edited by ghost
Loading

Description of changes

I've had this in my local tree for almost two months now; I kinda assumed somebody else would've been forced to merge a similar fix by now but I guess not. Having to make this fix after a rebase was how I discovered the new pass-a-function-to-mkDerivation feature!

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • powerpc64le-linux
    • mips64el-linux
  • Tested compilation of all many packages that depend on this change
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Aug 4, 2022
@nixos-discourse
Copy link
Copy Markdown

nixos-discourse commented Aug 4, 2022

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/proposal-move-values-from-derivation-attributes-to-function-arguments/20697/14

@ofborg ofborg bot added 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Aug 4, 2022
@ghost
Copy link
Copy Markdown
Author

ghost commented Aug 5, 2022

Ah, this got fixed by #176385.

@ghost ghost closed this Aug 5, 2022
@ghost ghost deleted the pr/stdenv/overlay-args branch January 23, 2024 06:50
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: stdenv Standard environment 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nixos-discourse