Skip to content

stdenv/adapters.nix: Fix for overlay style arguments#176385

Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom
hercules-ci:fix-overlay-style-stdenv-adapters
Jun 5, 2022
Merged

stdenv/adapters.nix: Fix for overlay style arguments#176385
Ericson2314 merged 1 commit intoNixOS:masterfrom
hercules-ci:fix-overlay-style-stdenv-adapters

Conversation

@roberth
Copy link
Copy Markdown
Member

@roberth roberth commented Jun 5, 2022 •
edited
Loading

Description of changes

Address #119942 (comment)

Perhaps performance could be improved by handling args manually later.

Things done
  • Built on platform(s)
    • x86_64-linux (it has to rebuild gcc; not great; doesn't seem to be caused by this PR)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Jun 5, 2022
@roberth roberth mentioned this pull request Jun 5, 2022
Merged
10 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Jun 5, 2022
@Ericson2314 Ericson2314 merged commit 82707a2 into NixOS:master Jun 5, 2022
@pwaller
Copy link
Copy Markdown
Contributor

pwaller commented Jun 13, 2022

@roberth @Ericson2314 is this a backport candidate? Thanks.

@roberth
Copy link
Copy Markdown
Member Author

roberth commented Jun 14, 2022

It's fix, it facilitates backports that depend on it and we haven't seen any issues with the fix after a week (probably) of it being in the channel, so +1 for backport.

@github-actions github-actions bot mentioned this pull request Jun 14, 2022
Merged
1 task
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 14, 2022

Successfully created backport PR #177587 for release-22.05.

@ghost ghost mentioned this pull request Aug 5, 2022
Closed
7 tasks
@trofi
Copy link
Copy Markdown
Contributor

trofi commented Mar 21, 2024

git bisect says it caused a regression of #277285 where pkgsStatic.php falls into infinite recursion:

$ nix build --no-link -f. pkgsStatic.php
error:
       … while calling a functor (an attribute set with a '__functor' attribute)
         at /home/slyfox/dev/git/nixpkgs-master/lib/customisation.nix:205:13:
          204|     in if missingArgs == {}
          205|        then makeOverridable f allArgs
             |             ^
          206|        # This needs to be an abort so it can't be caught with `builtins.tryEval`,

       … while evaluating a branch condition
         at /home/slyfox/dev/git/nixpkgs-master/lib/customisation.nix:108:7:
          107|     in
          108|       if isAttrs result then
             |       ^
          109|         result // {

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: stack overflow; max-call-depth exceeded
       at /home/slyfox/dev/git/nixpkgs-master/pkgs/development/interpreters/php/generic.nix:71:22:
           70|         let
           71|           fApplied = f attrs;
             |                      ^
           72|           attrs' = attrs // fApplied;

This was referenced Mar 21, 2024
Merged
Draft
@roberth
Copy link
Copy Markdown
Member Author

roberth commented Mar 21, 2024

I've spent some two hours on this and haven't found a solution.
My observations:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: stdenv Standard environment 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@roberth @pwaller @trofi @Ericson2314