Description of changes

This should be a little bit quicker, and by avoiding the intermediate package evaluation, it might also be more robust (but perhaps not robust against changes to overrideAttrs in make-derivation.nix, which probably should not be changed at all, considering its existing baggage).

• Attempted for stdenv/adapters.nix: Fix for overlay style arguments #176385 (comment) (but not a solution)

Stats:

• -0.2% in heap size

On second thought, I'm not convinced by the robustness argument. Why would the derivation fail to evaluate before the adapter is applied?

-0.2% is disappointing, but the number may be much more significant if the adapters are applied more broadly. Do we have a use case for applying them everywhere?

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.