jetbrains.jdk: openjdk11 (11.0.13-b1751.25) → openjdk17 (17.0.3-b469.37) by fabianhjr · Pull Request #183763 · NixOS/nixpkgs

fabianhjr · 2022-07-29T18:36:00Z

Description of changes

Two bundled updates, one of runtime (JBR) and IntelliJ IDEA Community Edition

I had been using the JBR 17 update for a while in previous versions of Idea Comumnity (only nuance were some warnings), with upstream moving the default forward this might be a good time to move nixpkgs default runtime forward too.

Things done

AnatolyPopov · 2022-07-29T18:57:18Z

Exactly the thing I was looking into today also! Will try to take a look soonish.

fabianhjr · 2022-07-29T21:15:45Z

Just as a note, other JetBrains packages should be tested too since the runtime update affect those.

AnatolyPopov · 2022-07-29T21:55:22Z

I was actually thinking about not dropping JBR11 but keeping both for sometime but will see

drupol · 2022-08-03T22:44:41Z

Are you going to update all the other Jetbrains IDEs ? Thanks.

fabianhjr · 2022-08-03T23:16:14Z

I was actually thinking about not dropping JBR11 but keeping both for sometime but will see

AFAIK all previous versions of editors (at least 2022.1) work great with JRE 17, there might have been some kinks/rough edges but JetBrains decided to move the default forward so no need to keep the previous versions.

fabianhjr · 2022-08-03T23:16:52Z

Are you going to update all the other Jetbrains IDEs ? Thanks.

Not really, I don't use any other editor and this PR hasn't gotten reviews/merged as it is.

AnatolyPopov · 2022-08-04T07:28:30Z

@fabianhjr I did take a look into these things and for some reason I still managed to build JBR17 locally.
It depends on openjdk17 that I believe is bootstrapped via openjdk17-bootstrap that is defined as

nixpkgs/pkgs/top-level/java-packages.nix

Line 126 in 511e56d

openjdk17-bootstrap = mkBootstrap adoptopenjdk-16

So when I'm trying to build JBR17 I'm getting an error with wrong bootstrap version complaining about openjdk16 and asking for JDK 11.

I also looked into the sources of JBR 17 and there required bootstrap versions are 17,18,19 AFAIR.
So I believe something goes wrong somewhere and seems the build for JBR17 needs to be changed.

Or can I you say what am I doing wrong?

drupol · 2022-08-04T15:01:44Z

Not really, I don't use any other editor and this PR hasn't gotten reviews/merged as it is.

Do you think you can update them? Other PRs related to jetbrains product are upgrading all the IDEs at once.

fabianhjr · 2022-08-04T16:20:27Z

@fabianhjr I did take a look into these things and for some reason I still managed to build JBR17 locally. It depends on openjdk17 that I believe is bootstrapped via openjdk17-bootstrap that is defined as

nixpkgs/pkgs/top-level/java-packages.nix

Line 126 in 511e56d

openjdk17-bootstrap = mkBootstrap adoptopenjdk-16

So when I'm trying to build JBR17 I'm getting an error with wrong bootstrap version complaining about openjdk16 and asking for JDK 11.

[..]

Or can I you say what am I doing wrong?

Seems like a darwin/macOS issue due to a typo, I believe it should be using version 17 to bootstrap. Checked the annotations and that line comes from this commit that doesn't mention using 16 to bootstrap 17 and probably went unnoticed until now.

a3401f6

fabianhjr · 2022-08-04T16:25:15Z

Ah, nvm, seems like there is something going on with JDK 17 and darwin/macOS.

#143836 (comment)

I have no access to that platform, could you try to change that bootstrap version to 17 and check if it works? @AnatolyPopov

fabianhjr · 2022-08-04T16:29:17Z

Seems like adopt-openjdk 17 has been stalled on darwin/macOS since march?

#165354

Could you try to cherry-pick af9e23d for testing tho adopt-openjdk-17 for bootstrapping @AnatolyPopov?

/cc @NixOS/darwin-maintainers

AnatolyPopov · 2022-08-05T06:22:37Z

@fabianhjr Thanks for digging into this but first of all I also do not have MacOS/Darwin, I'm on NixOS.
Second - I would suggest waiting for adoptopenjdk17 to be merged, there are several related PRs in progress.
Third - when I tried to build I tried with the JCEF version of JBR and there seems to be some issues #160468

I will try to run the build with JBR17 without JCEF a little later and we'll see how it will go.

drupol · 2022-08-05T11:57:42Z

I would also skip PHPStorm 2022.2 and use directly 2022.2.1 when it's out, see https://blog.jetbrains.com/phpstorm/2022/08/phpstorm-2022-2-1-preview/

AnatolyPopov · 2022-08-05T14:20:14Z

@drupol I believe this PR will not include any updates except Intellij unfortunately.
Also, @fabianhjr since there are some complications with JBR17 could we maybe create separate PR for regular version upgrade and keep this one focused on JBR? Lates Intellij anyways seems to be working fine with JBR11

fabianhjr · 2022-08-05T14:36:47Z

Done so, cherry-picked the "apdoptopenjdk: add 17.0.2" commit and change of bootstrap

pkgs/top-level/all-packages.nix

Mindavi

Diff LGTM, one question

Mindavi · 2022-08-09T05:36:06Z

There's a hash mismatch on Darwin too, see ofborg.

pkgs/development/compilers/jetbrains-jdk/default.nix

> With the IntelliJ IDEA 2022.2 EAP we are moving from JetBrains Runtime 11 (JBR11) to JetBrains Runtime 17 (JBR17). Starting with this build, all IntelliJ IDEA 2022.2 updates will come with JBR17. This will have the following effects: > - A significant performance improvement allowing faster and smoother IDE operation. > - Better security, as JBR17 is based on the latest OpenJDK LTS. > - Better rendering performance on macOS, as JetBrains Runtime 17 leverages Metal API. > - Increased accessibility on macOS, as JBR17 features integration with VoiceOver screen reader. > - Usage of Vector API designed to express vector computations that compile at runtime to vector instructions on supported CPU architectures, thus achieving performance superior to equivalent scalar computations. From: https://blog.jetbrains.com/idea/2022/05/intellij-idea-2022-2-eap-1/#JetBrains_Runtime

fabianhjr · 2022-09-19T01:53:34Z

Rebased due to #165354 merge

drupol · 2022-09-19T13:38:45Z

Current Jetbrains tools are broken when it comes to the use SSH remote connection, this is a huge problem for me and I guess for some other people as well.

It would be nice to move on with this. WDYT ?

veprbl · 2022-09-19T16:08:16Z

Seems like fcfdb62 fixes the fetching issue. But the build of openjfx fails on x86_64-linux.

fabianhjr · 2022-09-19T21:17:19Z

Current Jetbrains tools are broken when it comes to the use SSH remote connection, this is a huge problem for me and I guess for some other people as well.

It would be nice to move on with this. WDYT ?

A darwin contributor is needed to fix on darwin, on linux it works great.

drupol · 2022-09-19T21:20:12Z

Darwin maintainers cannot act as gatekeepers here. I propose to merge, and if there are issues on Darwin, then they should open a PR to fix it.

winterqt · 2022-09-19T22:05:19Z

Darwin maintainers cannot act as gatekeepers here. I propose to merge, and if there are issues on Darwin, then they should open a PR to fix it.

Who's saying they're... gatekeepers? Seems like a very odd word choice (that has weird implications with it).

If it'a a simple fix, there's no reason it can't be added to this PR. (Note: I have no clue if it is.)
And if it's not, then it's fine -- just make sure to mark it as broken on Darwin (ideally).

uri-canva · 2022-09-19T23:46:26Z

Re: merging without darwin working, this is why we have the support tiers, see https://github.com/NixOS/rfcs/blob/master/rfcs/0046-platform-support-tiers.md.

Since this problem has been reported to @NixOS/darwin-maintainers in #183763 (comment), I believe there has been enough time and this PR can be merged even while breaking darwin.

I'll remove my request changes to reflect that.

winterqt · 2022-09-19T23:55:35Z

We should probably mark it as broken on Darwin before merging.

Context: NixOS#183763

fabianhjr · 2022-09-20T00:57:10Z

Marked as broken on darwin

drupol · 2022-09-20T01:56:42Z

Who's saying they're... gatekeepers? Seems like a very odd word choice (that has weird implications with it).

If it'a a simple fix, there's no reason it can't be added to this PR. (Note: I have no clue if it is.)
And if it's not, then it's fine -- just make sure to mark it as broken on Darwin (ideally).

Oops... I apologize for the word I used, I didn't know it could be misinterpreted, I sincerely hope I haven't offended anyone.

What I merely meant here is that if the Darwin team do not reply to solicitations, then we shouldn't wait and move on. I also had the same kind of issue and never got any single reply from the team, so I moved on. This is the reason why I thought that gatekeeper was appropriate, wrongly.

I think marking the package as broken for Darwin is a better idea indeed.

Hope no hard feelings on this and thanks for the quick reaction on this.

winterqt · 2022-09-20T02:08:32Z

What I merely meant here is that if the Darwin team do not reply to solicitations, then we shouldn't wait and move on.

Agreed -- I didn't realize the call was sent out almost 2 months ago, and that's my fault. Sorry!

uri-canva · 2022-09-20T04:18:17Z

Thanks for the patience everyone, sorry for causing some confusion!

fabianhjr · 2022-09-20T04:21:54Z

No worries, hopefully someone with access to the darwin platform can sort the pending issue out.

drupol · 2022-09-20T04:42:28Z

Thanks 🙏

fabianhjr requested a review from edwtjo as a code owner July 29, 2022 18:36

fabianhjr requested review from AnatolyPopov and azahi July 29, 2022 18:37

ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jul 29, 2022

fabianhjr force-pushed the update-idea-community branch from 75fdc12 to e10d574 Compare August 5, 2022 14:23

fabianhjr changed the title ~~JetBrains Updates~~ jetbrains.jdk: openjdk11 (11.0.13-b1751.25) → openjdk17 (17.0.3-b469.32) Aug 5, 2022

ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. and removed 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 5, 2022

Mindavi reviewed Aug 9, 2022

View reviewed changes

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved

Mindavi approved these changes Aug 9, 2022

View reviewed changes

fabianhjr commented Aug 9, 2022

View reviewed changes

pkgs/development/compilers/jetbrains-jdk/default.nix Outdated Show resolved Hide resolved

fabianhjr added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 9, 2022

fabianhjr force-pushed the update-idea-community branch from afbe366 to 27a4de4 Compare September 19, 2022 01:53

bobby285271 removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 19, 2022

veprbl self-assigned this Sep 19, 2022

veprbl mentioned this pull request Sep 19, 2022

jetbrains.jdk: openjdk11 (11.0.13-b1751.25) → openjdk17 (17.0.3-b469.37) #191938

Closed

veprbl removed their assignment Sep 19, 2022

uri-canva self-requested a review September 19, 2022 23:46

jetbrains.jdk: mark as broken on darwin

420b83d

Context: NixOS#183763

khrj approved these changes Sep 20, 2022

View reviewed changes

uri-canva merged commit 9a3b426 into NixOS:master Sep 20, 2022

fabianhjr deleted the update-idea-community branch September 20, 2022 04:21

wamserma mentioned this pull request Sep 20, 2022

jetbrains.jdk: Fix darwin build #157511

Closed

13 tasks

fabianhjr mentioned this pull request Mar 10, 2023

jetbrains.jdk: 17.0.5-b653.25 → 17.0.6-b829.5 #220564

Merged

12 tasks

Uh oh!

Conversation

fabianhjr commented Jul 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of changes

Things done

Uh oh!

AnatolyPopov commented Jul 29, 2022

Uh oh!

fabianhjr commented Jul 29, 2022

Uh oh!

AnatolyPopov commented Jul 29, 2022

Uh oh!

drupol commented Aug 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabianhjr commented Aug 3, 2022

Uh oh!

fabianhjr commented Aug 3, 2022

Uh oh!

AnatolyPopov commented Aug 4, 2022

Uh oh!

drupol commented Aug 4, 2022

Uh oh!

fabianhjr commented Aug 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabianhjr commented Aug 4, 2022

Uh oh!

fabianhjr commented Aug 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AnatolyPopov commented Aug 5, 2022

Uh oh!

drupol commented Aug 5, 2022

Uh oh!

AnatolyPopov commented Aug 5, 2022

Uh oh!

fabianhjr commented Aug 5, 2022

Uh oh!

Uh oh!

Mindavi left a comment

Choose a reason for hiding this comment

Uh oh!

Mindavi commented Aug 9, 2022

Uh oh!

Uh oh!

fabianhjr commented Sep 19, 2022

Uh oh!

drupol commented Sep 19, 2022

Uh oh!

veprbl commented Sep 19, 2022

Uh oh!

fabianhjr commented Sep 19, 2022

Uh oh!

drupol commented Sep 19, 2022

Uh oh!

winterqt commented Sep 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

uri-canva commented Sep 19, 2022

Uh oh!

winterqt commented Sep 19, 2022

Uh oh!

fabianhjr commented Sep 20, 2022

Uh oh!

drupol commented Sep 20, 2022

Uh oh!

winterqt commented Sep 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

uri-canva commented Sep 20, 2022

Uh oh!

fabianhjr commented Sep 20, 2022

Uh oh!

drupol commented Sep 20, 2022

Uh oh!

Reviewers

Assignees

Labels

fabianhjr commented Jul 29, 2022 •

edited

Loading

drupol commented Aug 3, 2022 •

edited

Loading

fabianhjr commented Aug 4, 2022 •

edited

Loading

fabianhjr commented Aug 4, 2022 •

edited

Loading

winterqt commented Sep 19, 2022 •

edited

Loading

winterqt commented Sep 20, 2022 •

edited

Loading