Skip to content

raptor2: enable shared libraries by default#182727

Merged
Artturin merged 1 commit intoNixOS:staging-nextfrom
trofi:raptor2-dynamic-by-default
Jul 24, 2022
Merged

raptor2: enable shared libraries by default#182727
Artturin merged 1 commit intoNixOS:staging-nextfrom
trofi:raptor2-dynamic-by-default

Conversation

@trofi
Copy link
Copy Markdown
Contributor

@trofi trofi commented Jul 24, 2022 •
edited
Loading

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@trofi trofi mentioned this pull request Jul 24, 2022
Merged
13 tasks
@ofborg ofborg bot requested a review from MarcWeber July 24, 2022 17:58
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Jul 24, 2022
Artturin
Artturin reviewed Jul 24, 2022
View reviewed changes
pkgs/development/libraries/librdf/raptor2.nix
};

cmakeFlags = [
# Build defaults to static libraries.
Copy link
Copy Markdown
Member

@Artturin Artturin Jul 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we ask upstream to build shared instead of static by default?

Copy link
Copy Markdown
Contributor Author

@trofi trofi Jul 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable. Asked as dajobe/raptor#53

@Artturin Artturin merged commit 35875ee into NixOS:staging-next Jul 24, 2022
@trofi trofi deleted the raptor2-dynamic-by-default branch July 25, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Artturin Artturin Artturin approved these changes

@MarcWeber MarcWeber Awaiting requested review from MarcWeber

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trofi @Artturin