CMakeLists.txt: default to shared libraries by default#53
Merged
dajobe merged 1 commit intodajobe:masterfrom Dec 28, 2022
trofi:shared-by-default
Merged
CMakeLists.txt: default to shared libraries by default#53dajobe merged 1 commit intodajobe:masterfrom trofi:shared-by-default
dajobe merged 1 commit intodajobe:masterfrom
trofi:shared-by-default
Conversation
raptor2 provides a library and depends on a few other libraries on it's own (like libxml2). Some downstream projects are not very careful to include all the needed libraries from .pc files and use just raptor2 one. This sometimes causes linkage failures like `guitarix`: https://hydra.nixos.org/log/4hznma7pl7wvjdhm3x2lr84zpj07s2ax-guitarix-0.42.1.drv In this case linkage failure happens via underlinked `liblrdf.so`. While it's a bug in `liblrdf.so` I think it would be reasonable to enable shared libraries by default for use in distributions as is. This change enables shared library bu default.
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
raptor2 provides a library and depends on a few other libraries
on it's own (like libxml2).
Some downstream projects are not very careful to include all
the needed libraries from .pc files and use just raptor2 one.
This sometimes causes linkage failures like
guitarix:https://hydra.nixos.org/log/4hznma7pl7wvjdhm3x2lr84zpj07s2ax-guitarix-0.42.1.drv
In this case linkage failure happens via underlinked
liblrdf.so.While it's a bug in
liblrdf.soI think it would be reasonableto enable shared libraries by default for use in distributions as is.
This change enables shared library by default.