Skip to content

perlPackages: add default meta.mainProgram#176398

Merged
zimbatm merged 1 commit intoNixOS:masterfrom
zimbatm:perl-mainProgram
Jun 6, 2022
Merged

perlPackages: add default meta.mainProgram#176398
zimbatm merged 1 commit intoNixOS:masterfrom
zimbatm:perl-mainProgram

Conversation

@zimbatm
Copy link
Copy Markdown
Member

@zimbatm zimbatm commented Jun 5, 2022 •
edited
Loading

Description of changes

Because perl packages are prefixed with the perl version, it means that
the lib.getExe heuristic will never point to the binary name. So we
provide the meta.mainProgram that overrides that, using the original
pname or parsed name. It's not perfect but should yield better results
already.

If you're looking for an example: nix run .#pgbadger used to be broken

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@zimbatm
perlPackages: add default meta.mainProgram
e0f01e6 
Because perl packages are prefixed with the perl version, it means that
the `lib.getExe` heuristic will never point to the binary name. So we
provide the meta.mainProgram that overrides that, using the original
pname or parsed name. It's not perfect but should yield better results
already.
@zimbatm zimbatm requested review from stigtsp and zakame as code owners June 5, 2022 14:03
@zimbatm zimbatm force-pushed the perl-mainProgram branch from fbf76bf to 096d2b8 Compare June 5, 2022 14:09
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 5, 2022
@zimbatm zimbatm mentioned this pull request Jun 5, 2022
Merged
13 tasks
@zakame
Copy link
Copy Markdown
Member

zakame commented Jun 6, 2022

Maybe you could get in touch with @malob as he has #172413 also open that's adding this.

@zakame zakame mentioned this pull request Jun 6, 2022
Merged
13 tasks
@zimbatm zimbatm force-pushed the perl-mainProgram branch from 096d2b8 to e0f01e6 Compare June 6, 2022 12:31
@zimbatm
Copy link
Copy Markdown
Member Author

zimbatm commented Jun 6, 2022

Thanks for letting me know. I removed the individual package fixes to keep this PR focused on the default mainProgram change. I will merge this so the other PR can be rebased on top, I believe he will be able to remove a bunch of overrides.

@zimbatm zimbatm merged commit ff7b216 into NixOS:master Jun 6, 2022
@zimbatm zimbatm deleted the perl-mainProgram branch June 6, 2022 12:35
@malob
Copy link
Copy Markdown
Member

malob commented Jun 6, 2022

This will definitely get nix run working by default for a bunch of packages, but I want to check whether this is the right approach.

This change is explicitly setting the mainProgram to the incorrect value for many packages, so that others have the right value. I definitely get a little bit of a code smell from this, in that it seems like needing to do this is a symptom of a deeper underlying problem.

I don't have any real experience with perlPackages, so I could be missing important consideration, but if I was trying to implement a general fix for this issue, I'd first explore making a change to how Perl packages are packaged so that the pname reflects the name of the package (rather then being prefixed with the Perl version). This is how pythonPackages does things, pname is just the name of the package, and name is the packages's name prefixed with the Python version and suffixed with the package's version.

@zimbatm
Copy link
Copy Markdown
Member Author

zimbatm commented Jun 7, 2022

Sounds good, if you do that change then mine can be reverted. I'm not a perl maintainer so I was only looking for a minimal change.

@malob
Copy link
Copy Markdown
Member

malob commented Jun 7, 2022

#176792

SuperSandro2000 pushed a commit that referenced this pull request Jun 23, 2022
@malob
Revert "perlPackages: add default meta.mainProgram (#176398)"
61beb33 
This reverts commit ff7b216.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjornfor bjornfor bjornfor approved these changes

@stigtsp stigtsp Awaiting requested review from stigtsp

@zakame zakame Awaiting requested review from zakame

+1 more reviewer

@ckiee ckiee ckiee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zimbatm @zakame @malob @bjornfor @ckiee