Skip to content

ocamlPackages: add meta.mainProgram to many packages#172949

Merged
vbgl merged 1 commit intoNixOS:masterfrom
malob:ocamlPackages-mainProgram
May 14, 2022
Merged

ocamlPackages: add meta.mainProgram to many packages#172949
vbgl merged 1 commit intoNixOS:masterfrom
malob:ocamlPackages-mainProgram

Conversation

@malob
Copy link
Copy Markdown
Member

@malob malob commented May 14, 2022

Description of changes

Following up on #172228, this PR adds meta.mainProgram to packages in ocamlPackages that provide a single executable whose name differs from the package's name or pname.

With this PR I believe all packages in ocamlPackages that build on {aarch64,x86_64}-darwin and x86_64-linux, now have meta.mainProgram set if appropriate (if the provide a single executable).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. label May 14, 2022
@malob malob requested a review from vbgl May 14, 2022 00:28
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 14, 2022
@vbgl vbgl merged commit f7ef632 into NixOS:master May 14, 2022
@malob malob deleted the ocamlPackages-mainProgram branch May 14, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants